[PATCH] D159351: [Sema] Change order of displayed overloads in diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfebf5c97bba7: [Sema] Change order of displayed overloads in diagnostics (authored by ilya-biryukov). Changed prior to commit: https://reviews.llvm

[PATCH] D159351: [Sema] Change order of displayed overloads in diagnostics

ilya-biryukov updated this revision to Diff 557839. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Addressed comments - Added a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159351/new/ https://reviews

[PATCH] D159351: [Sema] Change order of displayed overloads in diagnostics

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think the changes should come with a release note so users know about the improved user experience (it would be great to show the code example from this patch summary in the re

[PATCH] D159351: [Sema] Change order of displayed overloads in diagnostics

ilya-biryukov added a comment. In D159351#4653687 , @shafik wrote: > You say "attempts to be a strict weak order" does that mean there are still > cases which will cause an assert or are we not sure? No, it's an actual strict weak order. It's a bad cho

[PATCH] D159351: [Sema] Change order of displayed overloads in diagnostics

shafik added a comment. You say "attempts to be a strict weak order" does that mean there are still cases which will cause an assert or are we not sure? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159351/new/ https://reviews.llvm.org/D159351 __

[PATCH] D159351: [Sema] Change order of displayed overloads in diagnostics

cor3ntin added a subscriber: aaron.ballman. cor3ntin added a comment. + @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159351/new/ https://reviews.llvm.org/D159351 ___ cfe-commits mailing l

[PATCH] D159351: [Sema] Change order of displayed overloads in diagnostics

ilya-biryukov added a comment. @cor3ntin any suggestions on how to proceed here? I hope the approach taken in the current patch should already provide meaningful and improved results in most cases. It only affects the diagnostics output, so changing or reverting it should be relatively easy in

[PATCH] D159351: [Sema] Change order of displayed overloads in diagnostics

rnk added a subscriber: cjdb. rnk added a comment. +@cjdb , do you have time to review this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159351/new/ https://reviews.llvm.org/D159351 ___ cfe-commits mai

[PATCH] D159351: [Sema] Change order of displayed overloads in diagnostics

cor3ntin added subscribers: hubert.reinterpretcast, rsmith, cor3ntin. cor3ntin added a comment. @hubert.reinterpretcast @rsmith Opinions on that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159351/new/ https://reviews.llvm.org/D159351 __

[PATCH] D159351: [Sema] Change order of displayed overloads in diagnostics

ilya-biryukov added reviewers: rnk, clang-language-wg. ilya-biryukov added a subscriber: rnk. ilya-biryukov added a comment. This change mainly tried to address the assertion failure in libc++, but got into the territory of changing the order of displayed overloads. Which might be a more complica

[PATCH] D159351: [Sema] Change order of displayed overloads in diagnostics

ilya-biryukov created this revision. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make it a strict weak order. Fixes #64121. Current implementation uses the definition the definition of orderi