[PATCH] D159312: [Headers] Remove a space in NULL define

ributzka added a comment. Thank you @aheejin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159312/new/ https://reviews.llvm.org/D159312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin added a comment. I uploaded D159383 , which removes the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159312/new/ https://reviews.llvm.org/D159312 ___

[PATCH] D159312: [Headers] Remove a space in NULL define

ributzka added a comment. Are we keeping the comment? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159312/new/ https://reviews.llvm.org/D159312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin added a comment. In D159312#4634617 , @dalias wrote: > Please report what you're actually trying to do that's breaking rather than > sending patches to align definitions that are not intended to be aligned. Basically, we tried to use `stddef.h`

[PATCH] D159312: [Headers] Remove a space in NULL define

dalias added a comment. Please report what you're actually trying to do that's breaking rather than sending patches to align definitions that are not intended to be aligned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159312/new/ https://reviews

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin added a comment. I believe this is better solved downstream, i.e., in musl. I'm not a musl developer but a user, but I can consider contributing a patch there. I'd like to remove the whitespace for now because it is currently breaking us and it had been that way for a long time anyway,

[PATCH] D159312: [Headers] Remove a space in NULL define

aaron.ballman added a comment. In D159312#4633989 , @dalias wrote: > I don't understand the motivation of trying to match musl's definition here. > musl explicitly **does not support** using a compiler-provided `stddef.h` or > other standard headers. If

[PATCH] D159312: [Headers] Remove a space in NULL define

dalias added a comment. I don't understand the motivation of trying to match musl's definition here. musl explicitly **does not support** using a compiler-provided `stddef.h` or other standard headers. If it's getting included, this is a symption of an include order problem that needs to be fix

[PATCH] D159312: [Headers] Remove a space in NULL define

aaron.ballman added inline comments. Comment at: clang/lib/Headers/__stddef_null.h:18-21 +// Don't add any whitespaces in ((void*)0) below! +// musl (https://www.musl-libc.org/) redefines `NULL` as such and redefinition +// with a different expression, even in terms of a single w

[PATCH] D159312: [Headers] Remove a space in NULL define

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef8121b109ef: [Headers] Remove a space in NULL define (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin added a comment. Done. Btw musl defines `NULL` in several places, not only `stdio.h`. It defines `NULL` in `local.h`, `stddef.h`, `stdio.h`, `stdlib.h`, `string.h`, `time.h`, `unistd.h`, and `wchar.h`. Not sure why. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin updated this revision to Diff 555201. aheejin added a comment. Add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159312/new/ https://reviews.llvm.org/D159312 Files: clang/lib/Headers/__stddef_null.h Index: clang/lib/Headers/__s

[PATCH] D159312: [Headers] Remove a space in NULL define

iana accepted this revision. iana added a comment. This revision is now accepted and ready to land. Can you add a comment that says the spacing is important please? Although why the heck is musl declaring NULL in stdio.h? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin added a comment. The added space actually caused emscripten's CI to break: https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket/8771230198259238865/+/u/Build_Emscripten__upstream_/stdout Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D159312: [Headers] Remove a space in NULL define

aheejin created this revision. aheejin added reviewers: iana, dschuff. Herald added a subscriber: wingo. Herald added a project: All. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There was no space in `((void *)0)` before D158709