[PATCH] D159263: [clang-tidy] misc-include-cleaner: avoid duplicated fixes

2023-09-05 Thread Ding Fei via Phabricator via cfe-commits
danix800 added a comment. Duplicated to https://github.com/llvm/llvm-project/pull/65431, abandon this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159263/new/ https://reviews.llvm.org/D159263 ___ c

[PATCH] D159263: [clang-tidy] misc-include-cleaner: avoid duplicated fixes

2023-09-05 Thread Ding Fei via Phabricator via cfe-commits
danix800 updated this revision to Diff 555867. danix800 edited the summary of this revision. danix800 added a comment. 1. Revert to internal set (not using `IncludeCleaner`); 2. Only do deduplication when not `areDiagsSelfContained()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D159263: [clang-tidy] misc-include-cleaner: avoid duplicated fixes

2023-09-05 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. In D159263#4638199 , @danix800 wrote: > If we have further plans from upstream on these checker/clang-format related > logic, I can wait and abandon this revision. Not at the moment, so please don't! > Or if such issue does ne

[PATCH] D159263: [clang-tidy] misc-include-cleaner: avoid duplicated fixes

2023-09-05 Thread Ding Fei via Phabricator via cfe-commits
danix800 added a comment. In D159263#4638167 , @kadircet wrote: > Thanks a lot for the patch @danix800 ! > > I initially was rather focused on behavior of this check in workflows that > require seeing "self-contained-diags", but also I rather see the bul

[PATCH] D159263: [clang-tidy] misc-include-cleaner: avoid duplicated fixes

2023-09-05 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. Thanks a lot for the patch @danix800 ! I initially was rather focused on behavior of this check in workflows that require seeing "self-contained-diags", but also I rather see the bulk-apply use cases as always requiring clang-format afterwards. Hence didn't really try

[PATCH] D159263: [clang-tidy] misc-include-cleaner: avoid duplicated fixes

2023-09-03 Thread Ding Fei via Phabricator via cfe-commits
danix800 added a comment. Ping @kadircet~, could you please take a look at this revision? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159263/new/ https://reviews.llvm.org/D159263 ___ cfe-commits mailin