[PATCH] D159256: [NFC][Clang] Remove redundant function definitions

jmmartinez added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159256/new/ https://reviews.llvm.org/D159256 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D159256: [NFC][Clang] Remove redundant function definitions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19550e79b50f: [NFC][Clang] Remove redundant function definitions (authored by jmmartinez). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D159256: [NFC][Clang] Remove redundant function definitions

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. In D159256#4630915 , @jmmartinez wrote: > In D159256#4630876 , @jhuber6 wrote: > >> In D159256#4630410

[PATCH] D159256: [NFC][Clang] Remove redundant function definitions

jmmartinez added a comment. In D159256#4630876 , @jhuber6 wrote: > In D159256#4630410 , @jmmartinez > wrote: > >> @jhuber6 I was wondering if there is a reason you kept 3 versions of >> `mergeDefaultFunctionDefi

[PATCH] D159256: [NFC][Clang] Remove redundant function definitions

jhuber6 added a comment. In D159256#4630410 , @jmmartinez wrote: > @jhuber6 I was wondering if there is a reason you kept 3 versions of > `mergeDefaultFunctionDefinitionAttributes` in > https://reviews.llvm.org/D152391 ? I believe it's because one was

[PATCH] D159256: [NFC][Clang] Remove redundant function definitions

jmmartinez added a comment. @jhuber6 I was wondering if there is a reason you kept 3 versions of `mergeDefaultFunctionDefinitionAttributes` in https://reviews.llvm.org/D152391 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159256/new/ https://rev

[PATCH] D159256: [NFC][Clang] Remove redundant function definitions

jmmartinez created this revision. jmmartinez added a reviewer: jhuber6. Herald added a project: All. jmmartinez requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There were 3 definitions of the mergeDefaultFunctionDefinitionAttributes functio