[PATCH] D159212: [MLIR] Allow dialects to disable CSE for certain operations

skatrak abandoned this revision. skatrak added a comment. I'll close this patch now, since the agreed approach has been to try using the `IsolatedFromAbove` trait and not to add an interface modifying the CSE pass behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D159212: [MLIR] Allow dialects to disable CSE for certain operations

skatrak added a comment. Thank you for your comments @jsjodin and @kiranchandramohan , I created an RFC here to try to get consensus on what the best solution shoul

[PATCH] D159212: [MLIR] Allow dialects to disable CSE for certain operations

kiranchandramohan added a comment. I think this requires an RFC in MLIR discourse to get some feedback from the experts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159212/new/ https://reviews.llvm.org/D159212 __

[PATCH] D159212: [MLIR] Allow dialects to disable CSE for certain operations

jsjodin added a comment. I'm not sure if we want to add an interface for every transform. Is there a way to have a generic solution to this, like a new trait or more general interface? It would be nice to avoid the case where a new transform will have to touch all the dialects, or a new op wil

[PATCH] D159212: [MLIR] Allow dialects to disable CSE for certain operations

skatrak created this revision. skatrak added reviewers: ftynse, kiranchandramohan, jsjodin, domada, agozillon, raghavendhra, TIFitis, shraiysh. Herald added subscribers: bviyer, Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurah