[PATCH] D159174: [Clang] Use stable_sort in AppendTargetMangling

2023-09-04 Thread Pavel Iliin via Phabricator via cfe-commits
ilinpv added a comment. In D159174#4635886 , @BeMg wrote: > I'm working on RISC-V FMV support, and we found the large set of extension > features is hard to maintain the priority that doesn't collision at all. On AArch64 for FMV we are using ##target_ve

[PATCH] D159174: [Clang] Use stable_sort in AppendTargetMangling

2023-09-01 Thread Piyou Chen via Phabricator via cfe-commits
BeMg added a comment. Thanks for the review. I'm working on RISC-V FMV support, and we found the large set of extension features is hard to maintain the priority that doesn't collision at all. Lack the appropriate priority, it will generate the random mangling name. The predictable mangling na

[PATCH] D159174: [Clang] Use stable_sort in AppendTargetMangling

2023-09-01 Thread Dave Green via Phabricator via cfe-commits
dmgreen added a comment. Do you have a test-case where they were out of order? Or is that dependent on the C++ library? I think I just moved this code from elsewhere when I changed it, but it sounds like a sensible change to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159174: [clang] Use stable_sort in AppendTargetMangling

2023-08-30 Thread Piyou Chen via Phabricator via cfe-commits
BeMg created this revision. Herald added a subscriber: mgrang. Herald added a project: All. BeMg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For the target features in the same priority, make sure it is not a random mangling name. Re