[PATCH] D158953: [analyzer] MmapWriteExecChecker: use getAs instead of castAs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2b6160ea3f9a: [analyzer] MmapWriteExecChecker: use getAs instead of castAs (authored by dingfei ). Repository: rG LLVM Github Mon

[PATCH] D158953: [analyzer] MmapWriteExecChecker: use getAs instead of castAs

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Land it, whenever you wish. Thanks! PS: usually we don't have a comment like that. The name of the function should give enough context, along with a // no-crash comment at the line where it

[PATCH] D158953: [analyzer] MmapWriteExecChecker: use getAs instead of castAs

danix800 updated this revision to Diff 553798. danix800 added a comment. Simplify testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158953/new/ https://reviews.llvm.org/D158953 Files: clang/lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.c

[PATCH] D158953: [analyzer] MmapWriteExecChecker: use getAs instead of castAs

danix800 added a comment. In D158953#4620125 , @steakhal wrote: > Could you please simplify the test case? > You could basically get rid of everything there, except for forwarding one > top level parameter as the proto argument to the mmap call. No prob

[PATCH] D158953: [analyzer] MmapWriteExecChecker: use getAs instead of castAs

steakhal added a comment. Could you please simplify the test case? You could basically get rid of everything there, except for forwarding one top level parameter as the proto argument to the mmap call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D158953: [analyzer] MmapWriteExecChecker: use getAs instead of castAs

danix800 created this revision. danix800 added a reviewer: steakhal. danix800 added a project: clang. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald adde