[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

2023-08-28 Thread Piotr Zegar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf0e2a5e260c2: [clang-tidy][readability] add Leading_upper_snake_case (authored by MasterCopy8GB, committed by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D158787?vs=553593&id=554022#toc

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

2023-08-28 Thread Steven Lewis via Phabricator via cfe-commits
MasterCopy8GB added a comment. In D158787#4621915 , @PiotrZSL wrote: > In D158787#4621587 , @MasterCopy8GB > wrote: > >> Hello @PiotrZSL, I do not have rights to commit to the LLVM repository. >> Could you pleas

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

2023-08-28 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added a comment. In D158787#4621587 , @MasterCopy8GB wrote: > Hello @PiotrZSL, I do not have rights to commit to the LLVM repository. Could > you please commit these changes for me? Thank you for all of your time and > effort! Under which use

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

2023-08-28 Thread Steven Lewis via Phabricator via cfe-commits
MasterCopy8GB added a comment. Hello @PiotrZSL, I do not have rights to commit to the LLVM repository. Could you please commit these changes for me? Thank you for all of your time and effort! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158787/new/ https://reviews.llvm.org/D158787 _

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

2023-08-25 Thread Steven Lewis via Phabricator via cfe-commits
MasterCopy8GB updated this revision to Diff 553593. MasterCopy8GB added a comment. Combine readability-identifier-naming improvements in release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158787/new/ https://reviews.llvm.org/D158787 Files: clang-tools-extra/clang-tidy/readab

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

2023-08-25 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. After you update release notes entry, it could land... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158787/new/ https://reviews.llvm.org/D158787

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

2023-08-25 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:240-245 ` check to emit proper warnings when a type forward declaration precedes its definition. +- Improved :doc:`readability-identifier-naming + ` allow for + ``Leading_upper_snake_cas

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

2023-08-25 Thread Steven Lewis via Phabricator via cfe-commits
MasterCopy8GB updated this revision to Diff 553550. MasterCopy8GB added a comment. Fix documentation comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158787/new/ https://reviews.llvm.org/D158787 Files: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp clang-t

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case issue 42451

2023-08-25 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added a comment. Upload full path to avoid "Context not available." Comment at: clang-tools-extra/docs/ReleaseNotes.rst:256 +- Improved :doc:`readability-identifier-naming + ` Leading_upper_snake_case -> put this entry in alphabetical order =

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case issue 42451

2023-08-25 Thread Steven Lewis via Phabricator via cfe-commits
MasterCopy8GB updated this revision to Diff 553504. MasterCopy8GB added a comment. Update diff with complete patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158787/new/ https://reviews.llvm.org/D158787 Files: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp cl

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case issue 42451

2023-08-25 Thread Steven Lewis via Phabricator via cfe-commits
MasterCopy8GB updated this revision to Diff 553494. MasterCopy8GB added a comment. Update documentation for issue 42451 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158787/new/ https://reviews.llvm.org/D158787 Files: clang-tools-extra/docs/ReleaseNotes.rst clang-tools-extra/docs/c

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

2023-08-25 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added a comment. And add reference to issue in commit description. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158787/new/ https://reviews.llvm.org/D158787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

2023-08-25 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:116-118 +- Improved :doc:`readability-identifier-naming + ` check to allow for + Leading_upper_snake_case naming convention. Wrong section, add it under "Changes in existing che

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

2023-08-24 Thread Steven Lewis via Phabricator via cfe-commits
MasterCopy8GB updated this revision to Diff 553294. MasterCopy8GB added a comment. Update documentation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158787/new/ https://reviews.llvm.org/D158787 Files: clang-tools-extra/docs/ReleaseNotes.rst clang-tools-extra/docs/clang-tidy/checks