yaxunl updated this revision to Diff 553250.
yaxunl added a comment.
fix test for strict fp
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158695/new/
https://reviews.llvm.org/D158695
Files:
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/CodeGen/fp-contract-fast-pragma.cpp
Index: clang
rjmccall added a comment.
Code change LGTM; I'll let you hash out the test feedback.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158695/new/
https://reviews.llvm.org/D158695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
arsenm added inline comments.
Comment at: clang/test/CodeGen/fp-contract-fast-pragma.cpp:77
+// CHECK: _Z13fp_contract_7f
+// CHECK: tail call contract float @llvm.sqrt.f32(float %a)
+ return __builtin_sqrtf(a);
This isn't demonstrating the strict support, proba
yaxunl updated this revision to Diff 553141.
yaxunl marked 3 inline comments as done.
yaxunl added a comment.
revised by comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158695/new/
https://reviews.llvm.org/D158695
Files:
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/CodeGen/fp-
yaxunl marked 4 inline comments as done.
yaxunl added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:501
if (CGF.Builder.getIsFPConstrained()) {
CodeGenFunction::CGFPOptionsRAII FPOptsRAII(CGF, E);
Function *F = CGF.CGM.getIntrinsic(ConstrainedIntrinsic
arsenm added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:501
if (CGF.Builder.getIsFPConstrained()) {
CodeGenFunction::CGFPOptionsRAII FPOptsRAII(CGF, E);
Function *F = CGF.CGM.getIntrinsic(ConstrainedIntrinsicID,
Src0->getType());
r
arsenm added inline comments.
Comment at: clang/test/CodeGen/fp-contract-fast-pragma.cpp:11
#pragma clang fp contract(fast)
- return a * b + c;
+ return a * b + c + __builtin_sqrtf(a);
}
Should leave the existing test function alone and add a new one. Also ca
rjmccall added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:501
if (CGF.Builder.getIsFPConstrained()) {
CodeGenFunction::CGFPOptionsRAII FPOptsRAII(CGF, E);
Function *F = CGF.CGM.getIntrinsic(ConstrainedIntrinsicID,
Src0->getType());
yaxunl created this revision.
yaxunl added reviewers: arsenm, rjmccall.
Herald added a project: All.
yaxunl requested review of this revision.
Herald added a subscriber: wdng.
Fix: https://github.com/llvm/llvm-project/issues/64653
https://reviews.llvm.org/D158695
Files:
clang/lib/CodeGen/CGBu
