This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
jansvoboda11 marked an inline comment as done.
Closed by commit rG7d1565727dad: [clang][modules] Move `UNHASHED_CONTROL_BLOCK`
up in the AST file (authored by jansvobod
jansvoboda11 marked 5 inline comments as done.
jansvoboda11 added inline comments.
Comment at: clang/lib/Serialization/ASTWriter.cpp:1169
+ writeSignature(Sig, Out);
+ std::copy_n(Out.begin(), Out.size(), Buffer.begin() + Offset);
+};
benlangmuir wr
jansvoboda11 updated this revision to Diff 552897.
jansvoboda11 added a comment.
Early return.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158573/new/
https://reviews.llvm.org/D158573
Files:
clang/include/clang/Basic/Module.h
clang/include/c
jansvoboda11 updated this revision to Diff 552896.
jansvoboda11 added a comment.
Use `Stream::BackpatchWord()` instead of manipulating `Buffer` directly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158573/new/
https://reviews.llvm.org/D158573
Fi
benlangmuir added inline comments.
Comment at: clang/lib/Serialization/ASTWriter.cpp:1169
+ writeSignature(Sig, Out);
+ std::copy_n(Out.begin(), Out.size(), Buffer.begin() + Offset);
+};
jansvoboda11 wrote:
> I don't feel great about removing `const
jansvoboda11 added a comment.
Good suggestions all around, thanks!
Comment at: clang/lib/Serialization/ASTWriter.cpp:1169
+ writeSignature(Sig, Out);
+ std::copy_n(Out.begin(), Out.size(), Buffer.begin() + Offset);
+};
I don't feel great about rem
benlangmuir added inline comments.
Comment at: clang/lib/Serialization/ASTReader.cpp:2685
+ for (unsigned I = 0; I < ASTFileSignature::size; ++I)
+Sig[I] = endian::readNext(Blob);
+ return Sig;
uint8_t has no endianness and has alignment 1 anyway; you can j
jansvoboda11 created this revision.
jansvoboda11 added a reviewer: benlangmuir.
Herald added subscribers: ributzka, arphaman.
Herald added a project: All.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
When loading (transitive
