[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

serge-sans-paille added a comment. In D158558#4616275 , @efocht wrote: > Can somebody please revert this patch? It kills all builds on > https://lab.llvm.org/buildbot/#/builders/91 since yesterday. > @serge-sans-paille ? This got reverted by https://r

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

efocht added a comment. Can somebody please revert this patch? It kills all builds on https://lab.llvm.org/buildbot/#/builders/91 since yesterday. @serge-sans-paille ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158558/new/ https://reviews.llvm

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

vvereschaka added a comment. Hi @serge-sans-paille, also on this builder: https://lab.llvm.org/buildbot/#/builders/60/builds/13587 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158558/new/ https://reviews.llvm.org/D158558

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

dyung added a comment. Hi @serge-sans-paille, the test you added seems to be failing on some bots. Can you take a look and revert if you need time to investigate? - https://lab.llvm.org/buildbot/#/builders/139/builds/48265 - https://lab.llvm.org/buildbot/#/builders/216/builds/26208 Repository:

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdbccf3c6f13d: [clang] - Add missing builtin name to AtomicExpr JSON dump (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHA

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D158558#4613139 , @serge-sans-paille wrote: > I don't have a strong opinion on the synchronization with `TextNodeDumper`. > I'm pret

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

serge-sans-paille added a comment. I don't have a strong opinion on the synchronization with `TextNodeDumper`. I'm pretty sure I didn't update it while adding fields for the Attribute nodes though... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

aaron.ballman added a comment. The changes LGTM as far as they go, but should we also update the `TextNodeDumper` at the same time? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158558/new/ https://reviews.llvm.org/D158558 ___

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

serge-sans-paille created this revision. serge-sans-paille added a reviewer: aaron.ballman. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As a side effect, introduce AtomicExpr::getOpAsString