[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

2023-08-23 Thread Soumi Manna via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG30c60ec52f15: [NFC][CLANG] Fix static analyzer bugs about large copy by values (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

2023-08-23 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Failure is unrelated to my patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158522/new/ https://reviews.llvm.org/D158522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

2023-08-22 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. In D158522#4607628 , @tahonermann wrote: > Looks fine to me! Thanks @tahonermann for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158522/new/ https://reviews.llvm.org/D158522 _

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

2023-08-22 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann accepted this revision. tahonermann added a comment. Looks fine to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158522/new/ https://reviews.llvm.org/D158522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

2023-08-22 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 552428. Manna added a comment. Fix build errors. I have updated CodeGenFunction.h as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158522/new/ https://reviews.llvm.org/D158522 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CodeGen

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

2023-08-22 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. In D158522#4607054 , @sdesmalen wrote: > It indeed makes sense to pass these by reference. Thank you @sdesmalen for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158522/new/

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

2023-08-22 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. It indeed makes sense to pass these by reference. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158522/new/ https://reviews.llvm.org/D1585

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

2023-08-22 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added reviewers: aaron.ballman, tahonermann. Herald added subscribers: ctetreau, manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clan