[PATCH] D158415: [Lex] Handle repl_input_end in Preprocessor::LexAll()

2023-09-14 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. The idea LGTM when D158413 lands, even if that lands with a slightly different design. (IOW, once D158413 lands, feel free to push this change without furth

[PATCH] D158415: [Lex] Handle repl_input_end in Preprocessor::LexAll()

2023-09-14 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. This revision cannot land without https://reviews.llvm.org/D158413 and for that one I really want to have feedback from somebody working in that area... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158415/new/ https://re

[PATCH] D158415: [Lex] Handle repl_input_end in Preprocessor::LexAll()

2023-09-14 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added a comment. @Hahnfeld, let's move forward and rely on a post-commit review here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158415/new/ https://reviews.llvm.org/D158415 ___ cfe-commi

[PATCH] D158415: [Lex] Handle repl_input_end in Preprocessor::LexAll()

2023-09-14 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158415/new/ https://reviews.llvm.org/D158415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D158415: [Lex] Handle repl_input_end in Preprocessor::LexAll()

2023-09-04 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158415/new/ https://reviews.llvm.org/D158415

[PATCH] D158415: [Lex] Handle repl_input_end in Preprocessor::LexAll()

2023-09-04 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158415/new/ https://reviews.llvm.org/D158415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D158415: [Lex] Handle repl_input_end in Preprocessor::LexAll()

2023-08-21 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld created this revision. Hahnfeld added reviewers: aaron.ballman, v.g.vassilev. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes many unit tests when trying to enable `IncrementalExtens