[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3116d60494f2: [Lex] Introduce Preprocessor::LexTokensUntilEOF() (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

Hahnfeld added inline comments. Comment at: clang/lib/Lex/Preprocessor.cpp:1000 + std::vector toks; + while (1) { +Token tok; v.g.vassilev wrote: > Hahnfeld wrote: > > aaron.ballman wrote: > > > v.g.vassilev wrote: > > > > aaron.ballman wrote: > > > > > Hah

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

Hahnfeld updated this revision to Diff 557603. Hahnfeld marked an inline comment as done. Hahnfeld added a comment. Address minor naming convention nit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158413/new/ https://reviews.llvm.org/D158413 Files: clang/include/clang/Lex/Preproces

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor naming nit. I think finding a way to unify with `SkipUntil` would be good follow-up work, though. Comment at: clang/lib/Lex/Preprocesso

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

v.g.vassilev added a comment. This looks reasonable to me, but I'd wait for @aaron.ballman greenlight as he seems to have had more comments/ideas. Comment at: clang/lib/Lex/Preprocessor.cpp:1000 + std::vector toks; + while (1) { +Token tok; Hahnfeld wrot

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

Hahnfeld added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158413/new/ https://reviews.llvm.org/D158413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

Hahnfeld added inline comments. Comment at: clang/lib/Lex/Preprocessor.cpp:1000 + std::vector toks; + while (1) { +Token tok; aaron.ballman wrote: > v.g.vassilev wrote: > > aaron.ballman wrote: > > > Hahnfeld wrote: > > > > aaron.ballman wrote: > > > > > I'

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

Hahnfeld updated this revision to Diff 556834. Hahnfeld marked an inline comment as done. Hahnfeld added a comment. Handle all of `tok::unknown, tok::eof, tok::eod`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158413/new/ https://reviews.llvm.org/D158413 Files: clang/include/clang/

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

aaron.ballman added inline comments. Comment at: clang/lib/Lex/Preprocessor.cpp:1000 + std::vector toks; + while (1) { +Token tok; v.g.vassilev wrote: > aaron.ballman wrote: > > Hahnfeld wrote: > > > aaron.ballman wrote: > > > > I'd prefer not to assume the

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

v.g.vassilev added inline comments. Comment at: clang/lib/Lex/Preprocessor.cpp:1000 + std::vector toks; + while (1) { +Token tok; aaron.ballman wrote: > Hahnfeld wrote: > > aaron.ballman wrote: > > > I'd prefer not to assume the token stream has an EOF toke

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

aaron.ballman added inline comments. Comment at: clang/lib/Lex/Preprocessor.cpp:1000 + std::vector toks; + while (1) { +Token tok; Hahnfeld wrote: > aaron.ballman wrote: > > I'd prefer not to assume the token stream has an EOF token (perhaps the > > stream

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

Hahnfeld marked 2 inline comments as done. Hahnfeld added inline comments. Comment at: clang/lib/Lex/Preprocessor.cpp:998 +std::vector Preprocessor::LexAll() { + std::vector toks; aaron.ballman wrote: > v.g.vassilev wrote: > > Shouldn't we take the results as

[PATCH] D158413: [Lex] Introduce Preprocessor::LexTokensUntilEOF()

Hahnfeld updated this revision to Diff 556791. Hahnfeld retitled this revision from "[Lex] Introduce Preprocessor::LexAll()" to "[Lex] Introduce Preprocessor::LexTokensUntilEOF()". Hahnfeld edited the summary of this revision. Hahnfeld added a comment. Rename to `Preprocessor::LexTokensUntilEOF()