[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

2023-08-29 Thread Brad Smith via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3476332e453: [Driver] move DragonFly header search path management to the driver (authored by brad). Changed prior to commit: https://reviews.llv

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

2023-08-29 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Comment at: clang/lib/Lex/InitHeaderSearch.cpp:331 - case llvm::Triple::DragonFly: -AddPath("/usr/include/c++/5.0", CXXSystem, false); -break; ---

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

2023-08-29 Thread Brad Smith via Phabricator via cfe-commits
brad added inline comments. Comment at: clang/lib/Lex/InitHeaderSearch.cpp:331 - case llvm::Triple::DragonFly: -AddPath("/usr/include/c++/5.0", CXXSystem, false); -break; MaskRay wrote: > 5.0 becomes 8.0 after move? > 5.0 becomes 8.0 after move? Read wh

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

2023-08-29 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/lib/Lex/InitHeaderSearch.cpp:331 - case llvm::Triple::DragonFly: -AddPath("/usr/include/c++/5.0", CXXSystem, false); -break; 5.0 becomes 8.0 after move? Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

2023-08-28 Thread Brad Smith via Phabricator via cfe-commits
brad updated this revision to Diff 554140. brad added a comment. Remove C_INCLUDE_DIRS bits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158376/new/ https://reviews.llvm.org/D158376 Files: clang/lib/Driver/ToolChains/DragonFly.cpp clang/lib/

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

2023-08-28 Thread Brad Smith via Phabricator via cfe-commits
brad added a comment. David? Frederic? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158376/new/ https://reviews.llvm.org/D158376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

2023-08-24 Thread Brad Smith via Phabricator via cfe-commits
brad updated this revision to Diff 553310. brad added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158376/new/ https://reviews.llvm.org/D158376 Files: clang/lib/Driver/ToolChains/DragonFly.cpp clang/lib/Driver/ToolChains/Dr

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

2023-08-20 Thread Brad Smith via Phabricator via cfe-commits
brad updated this revision to Diff 551872. brad added a comment. Also use concat() in addLibStdCxxIncludePaths(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158376/new/ https://reviews.llvm.org/D158376 Files: clang/lib/Driver/ToolChains/Drago

[PATCH] D158376: [Driver] move DragonFly header search path management to the driver

2023-08-20 Thread Brad Smith via Phabricator via cfe-commits
brad created this revision. brad added a reviewer: devnexen. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. As has been done for other OS's. Move the header path management to the driver. Also I noticed with ht