[PATCH] D158254: Fixing the memory leak using split() instead of strtok

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3c8f16fc32c: Fixing the memory leak using split() instead of strtok (authored by hchilama, committed by abhina.sreeskantharajan). Repository: rG

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

hchilama added a comment. Please use my Intel email Chilamantula, Harini . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158254/new/ https://reviews.llvm.org/D158254 ___ cfe-commits mailing list cfe-com

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

abhina.sreeskantharajan added a comment. In D158254#4607027 , @hchilama wrote: > Hi @abhina.sreeskantharajan , Thanks for letting me know the process and > please help me in commiting this patch. I'd like to put your name and email as the commit's autho

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

hchilama added a comment. Hi @abhina.sreeskantharajan , Thanks for letting me know the process and please help me in commiting this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158254/new/ https://reviews.llvm.org/D158254

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

abhina.sreeskantharajan added a comment. In D158254#4605050 , @hchilama wrote: > Hi @abhina.sreeskantharajan can I please know the next process on how to land > this revision to opensource? Usually you need to have someone with commit access commit the

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

hchilama added a comment. Hi @abhina.sreeskantharajan can I please know the next process on how to land this revision to opensource? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158254/new/ https://reviews.llvm.org/D158254 __

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. In D158254#4603765 , @hchilama wrote: > Hi @abhina.sreeskantharajan I have verified the fix aganist the clang-format,

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

hchilama added a comment. Hi @abhina.sreeskantharajan I have verified the fix aganist the clang-format, seems fine. (FYI: I saw clean build on Friday) I have modified this object with the edit policy "All Users" Please let me know if I need to do anything else here? Repository: rG LLVM Gith

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

abhina.sreeskantharajan added a comment. It seems like clang-format might be failing with this patch which should be fixed first. And I think I cannot actually accept this patch because I see the following `hchilama created this object with edit policy "Administrators".` Repository: rG LLVM

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

abhina.sreeskantharajan added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158254/new/ https://reviews.llvm.org/D158254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

hchilama accepted this revision. hchilama added a comment. This revision is now accepted and ready to land. Using the split() instead of strtok to improve the performance Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158254/new/ https://reviews.llv

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

hchilama created this revision. hchilama created this object with edit policy "Administrators". Herald added a project: All. hchilama requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://rev