[PATCH] D158252: Fix regression of D157680

2023-08-23 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/Driver/x86-no-gather-no-scatter.cpp:2 /// Tests -mno-gather and -mno-scatter -// RUN: %clang -c -mno-gather -### %s 2>&1 | FileCheck --check-prefix=NOGATHER %s -// RUN: %clang_cl -c /Qgather- -### %s 2>&1 | FileCheck --chec

[PATCH] D158252: Fix regression of D157680

2023-08-18 Thread Matt D. via Phabricator via cfe-commits
Matt added inline comments. Comment at: llvm/test/CodeGen/X86/x86-prefer-no-gather-no-scatter.ll:3 +; RUN: llc -mtriple=x86_64-unknown-linux-gnu -mattr=+avx2,+fast-gather %s -o - | FileCheck %s --check-prefixes=GATHER +; RUN: llc -mtriple=x86_64-unknown-linux-gnu -mattr=+avx2,+

[PATCH] D158252: Fix regression of D157680

2023-08-18 Thread Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7cf9bbfde5e: Fix regression of D157680 (authored by XinWang10, committed by xin10.wang ). Repository: rG LLVM

[PATCH] D158252: Fix regression of D157680

2023-08-18 Thread Wang, Xin via Phabricator via cfe-commits
XinWang10 added a comment. In D158252#4597933 , @Hahnfeld wrote: > LG. IMHO such fixes to the tests can be committed without review :) OK, Thanks for explanation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D158252: Fix regression of D157680

2023-08-18 Thread Kan Shengchen via Phabricator via cfe-commits
skan accepted this revision. skan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158252/new/ https://reviews.llvm.org/D158252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D158252: Fix regression of D157680

2023-08-18 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LG. IMHO such fixes to the tests can be committed without review :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158252/new/ https://review

[PATCH] D158252: Fix regression of D157680

2023-08-17 Thread Wang, Xin via Phabricator via cfe-commits
XinWang10 created this revision. Herald added a subscriber: pengfei. Herald added a project: All. XinWang10 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Test cases in D157680 should be