This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGff08c8e57e39: [SEH] Fix wrong argument passes to the call of
OutlinedFinally. (authored by jyu2).
Changed prior to commit:
https://reviews.llvm.or
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
Comment at: clang/lib/CodeGen/CGCleanup.cpp:881
+ // to indicate abnormal termination)
+ const FunctionDecl *FD = dyn_cast_or_null(CurFuncDecl);
if (
jyu2 added inline comments.
Comment at: clang/lib/CodeGen/CGCleanup.cpp:882
if (!Scope.hasBranchThroughs() && !HasFixups && !HasFallthrough &&
- Scope.getNumBranchAfters() == 1) {
+ !getLangOpts().EHAsynch && Scope.getNumBranchAfters() == 1) {
as
jyu2 updated this revision to Diff 552157.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158233/new/
https://reviews.llvm.org/D158233
Files:
clang/lib/CodeGen/CGCleanup.cpp
clang/test/CodeGen/exceptions-seh-finally.c
clang/test/CodeGen/windows
rnk added inline comments.
Comment at: clang/lib/CodeGen/CGCleanup.cpp:882
if (!Scope.hasBranchThroughs() && !HasFixups && !HasFallthrough &&
- Scope.getNumBranchAfters() == 1) {
+ !getLangOpts().EHAsynch && Scope.getNumBranchAfters() == 1) {
ass
rnk added inline comments.
Comment at: clang/lib/CodeGen/CGCleanup.cpp:882
if (!Scope.hasBranchThroughs() && !HasFixups && !HasFallthrough &&
- Scope.getNumBranchAfters() == 1) {
+ !getLangOpts().EHAsynch && Scope.getNumBranchAfters() == 1) {
ass
jyu2 created this revision.
jyu2 added reviewers: asmith, tentzen, rnk, efriedma, pengfei.
jyu2 added a project: clang.
Herald added a project: All.
jyu2 requested review of this revision.
When return out of __try block. In this test case, currently "false" is
passed to the OutlinedFinally call,
