[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

2023-08-23 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. In D158227#4610219 , @dyung wrote: > In D158227#4610097 , @Manna wrote: > >> The failure seems unrelated to my change. > > Hi @Manna, I'm not sure which failure you are referring to, but the

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

2023-08-23 Thread Douglas Yung via Phabricator via cfe-commits
dyung added a comment. In D158227#4610097 , @Manna wrote: > The failure seems unrelated to my change. Hi @Manna, I'm not sure which failure you are referring to, but there is a test failure on at least 2 build bots that seems to have been caused by your

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

2023-08-23 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. The failure seems unrelated to my change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158227/new/ https://reviews.llvm.org/D158227 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

2023-08-23 Thread Soumi Manna via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e150adaea7b: [NFC][clang] EditedSource::applyRewrites - useless call (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

2023-08-22 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Thank you @aaron.ballman for reviews and feedbacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158227/new/ https://reviews.llvm.org/D158227 ___ cfe-commits mailing list cfe-comm

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

2023-08-18 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! This is an NFC change that doesn't require additional testing because `CurEnd` is only used in an assertion, not for any of the function's semantics. Repository: rG LLVM

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

2023-08-17 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added reviewers: RKSimon, aaron.ballman, tahonermann. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Fixes https://github.com/llvm/llvm-project/issues/53426 Repository: rG LLVM Github Monorepo https://rev