cseo added a comment.
Ping. Any other comments/concerns?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158135/new/
https://reviews.llvm.org/D158135
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
cseo added a comment.
FWIW, the pre-merge checks failed due to a problem with git-clang-format, not
the tests themselves (they are all green).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158135/new/
https://reviews.llvm.org/D158135
cseo updated this revision to Diff 553467.
cseo added a comment.
Address issues from the last revision.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158135/new/
https://reviews.llvm.org/D158135
Files:
clang/include/clang/Basic/Builtins.def
cl
shafik added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3567
+ case Builtin::BI__builtin_bcopy: {
+Address Dest = EmitPointerWithAlignment(E->getArg(1));
+Address Src = EmitPointerWithAlignment(E->getArg(0));
Maybe it is better to do th
cseo updated this revision to Diff 552370.
cseo added a comment.
Fix builtin definition and tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158135/new/
https://reviews.llvm.org/D158135
Files:
clang/include/clang/Basic/Builtins.def
clang/li