[PATCH] D158055: [clang][AST] Added some missing setter methods

2023-08-17 Thread Timo Stripf via Phabricator via cfe-commits
strimo378 abandoned this revision. strimo378 added a comment. Alright, thank you for the review... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158055/new/ https://reviews.llvm.org/D158055 ___ cfe-commi

[PATCH] D158055: [clang][AST] Added some missing setter methods

2023-08-17 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D158055#4594863 , @strimo378 wrote: > Yes, I have a need for these setters :) but I cannot decide if the LLVM > project in general or other people could profit from it. > > I am working on a C++-to-C transpiler based on

[PATCH] D158055: [clang][AST] Added some missing setter methods

2023-08-17 Thread Timo Stripf via Phabricator via cfe-commits
strimo378 added a comment. Yes, I have a need for these setters :) but I cannot decide if the LLVM project in general or other people could profit from it. I am working on a C++-to-C transpiler based on clang. Other clang-based tool typically modify the intput file based on FileLocation informa

[PATCH] D158055: [clang][AST] Added some missing setter methods

2023-08-16 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. We typically only add these sorts of functions when we need them; do you have a need to add setters? (Oftentimes, we don't want setters because we want the AST nodes to be created in the correct state when possible; we do add some setters because of AST deserializ

[PATCH] D158055: [clang][AST] Added some missing setter methods

2023-08-16 Thread Timo Stripf via Phabricator via cfe-commits
strimo378 added a comment. I added some missing (simple) setter methods to Decl and Expr classes. I did not comment them since typically simple setter methods are uncommented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158055/new/ https://revie

[PATCH] D158055: [clang][AST] Added some missing setter methods

2023-08-16 Thread Timo Stripf via Phabricator via cfe-commits
strimo378 created this revision. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158055 Files: clang/include/clang/AST/Decl.h clang