[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG38c92c1ee2f0: [AArch64] Add patterns for FMADD, FMSUB (authored by overmighty, committed by dzhidzhoev). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

overmighty added a comment. Ping. If you would like the current patch with `extractelt` to be committed, please commit it as "OverMighty ". Thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158008/new/ https://reviews.llvm.org/D158008 __

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

dzhidzhoev accepted this revision. dzhidzhoev added a subscriber: arsenm. dzhidzhoev added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:5393 + (EXTRACT_SUBREG V128:$Rn, hsub), FPR16:$Rm, FPR16:$Ra)>; + } + overmighty w

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

overmighty added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:5393 + (EXTRACT_SUBREG V128:$Rn, hsub), FPR16:$Rm, FPR16:$Ra)>; + } + dzhidzhoev wrote: > BTW, these lines add some patterns for fnmadd. Could you add some

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

overmighty updated this revision to Diff 551754. overmighty added a reviewer: dzhidzhoev. overmighty added a comment. - Rebase new upstream commits. - Replace usage of deprecated `vector_extract` with `extractelt` in new patterns. - Add `f16` operators before `EXTRACT_SUBREG`s in new `*Hrrr` inst

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

dzhidzhoev added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:5418 + (EXTRACT_SUBREG V128:$Rn, dsub), FPR64:$Rm, FPR64:$Ra)>; } Is it possible to use extractelt here? Since vector_extract is marked as deprecated in

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

dzhidzhoev added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:5393 + (EXTRACT_SUBREG V128:$Rn, hsub), FPR16:$Rm, FPR16:$Ra)>; + } + BTW, these lines add some patterns for fnmadd. Could you add some tests for them? Or

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

dzhidzhoev added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:5381-5393 + let Predicates = [HasFullFP16] in { + def : Pat<(f16 (node (f16 FPR16:$Rn), + (f16 (vector_extract (v8f16 V128:$Rm), (i64 0))), +

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

overmighty added a comment. The crashes in complex-deinterleaving-f16-mul.ll and fp16_intrinsic_lane.ll seem to be caused by D156831 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158008/new/ https://reviews.llvm.org/D158008 _

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

overmighty added a comment. If this still looks good to you, please commit it as "OverMighty ". Thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158008/new/ https://reviews.llvm.org/D158008 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

overmighty updated this revision to Diff 551193. overmighty added a comment. Add tests for A[0]*B+C patterns. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158008/new/ https://reviews.llvm.org/D158008 Files: clang/test/CodeGen/aarch64-neon-scalar-x-indexed-elem-constrained.c llvm/l

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

samtebbs accepted this revision. samtebbs added a comment. This revision is now accepted and ready to land. Thanks, this looks good to me with any extra tests required by David's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158008/new/ ht

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

dmgreen added a comment. It looks like there are patterns for A[0]*B+C and B*A[0]*C to handle commutivity. Are there tests for both forms too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158008/new/ https://reviews.llvm.org/D158008

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

overmighty created this revision. overmighty added reviewers: dmgreen, john.brawn, SjoerdMeijer. Herald added subscribers: arphaman, hiraditya, kristof.beyls. Herald added a project: All. overmighty requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llv