[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

DavidSpickett added a comment. We also had a failure looking for the mangled name on Windows on Arm: https://lab.llvm.org/buildbot/#/builders/65/builds/10954 The triple fix may take care of that too. > Also, consider spreading out commits a bit so that if one breaks something, > it's easily to

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

hans added a comment. Since reverting seems non-trivial, I added a triple in https://github.com/llvm/llvm-project/commit/7a1735cd05c2bc0c336f122f01fb35de66e85e16 which I believe should fix the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

thakis added a comment. In D157808#4587014 , @thakis wrote: > Hello, one of the many dump commits broke tests on macOS: > http://45.33.8.238/macm1/67030/step_7.txt > > Please take a look and revert for now if it takes a while to fix. > > Also, consider s

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

thakis added a comment. Hello, one of the many dump commits broke tests on macOS: http://45.33.8.238/macm1/67030/step_7.txt Please take a look and revert for now if it takes a while to fix. Also, consider spreading out commits a bit so that if one breaks something, it's easily to see which one

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

dyung added a comment. Hi @serge-sans-paille, your change is causing the test you modified, `clang/test/AST/ast-dump-attr-json.cpp` to fail. Can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/47461 https://lab.llvm.org/buildbot/#/builders/109/builds/71264 Repository: rG

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2107d87c5a91: [clang] Add missing field to VisibilityAttr json AST dump (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157808/new/ https://reviews.llvm.org/D157808 ___ cfe-commits mailing lis

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

serge-sans-paille updated this revision to Diff 549717. serge-sans-paille added a comment. Fix typo in example CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157808/new/ https://reviews.llvm.org/D157808 Files: clang/include/clang/AST/JSONNodeDumper.h clang/lib/AST/JSONNodeDumper.cpp

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

serge-sans-paille created this revision. serge-sans-paille added a reviewer: aaron.ballman. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://review