[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG62f769aa82f6: [Headers] Add missing __need_ macros to stdarg.h (authored by iana). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157793/new/ https://reviews

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

iana updated this revision to Diff 550823. iana added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157793/new/ https://reviews.llvm.org/D157793 Files: clang/lib/Headers/stdarg.h clang/test/Headers/stdarg.c clang/test/Heade

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

iana added a comment. In D157793#4588909 , @jyknight wrote: > I'm a bit confused by this change vs its description. > > It looks like stdarg already supported `__need___va_list`, which is what you > said Apple needs. Does Apple //also// require the other

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

jyknight added a comment. I'm a bit confused by this change vs its description. It looks like stdarg already supported `__need___va_list`, which is what you said Apple needs. Does Apple //also// require the other __need_va_copy/etc, too? If not, why add support for them? (I think we should pref

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/Headers/stdarg.c:34 +__va_copy(g, v); +va_copy(g, v); // c89-error{{implicit}} c89-note{{va_copy}} c99-no-diagnostics +} -

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

iana added inline comments. Comment at: clang/test/Headers/stdarg.c:34 +__va_copy(g, v); +va_copy(g, v); // c89-error{{implicit}} c89-note{{va_copy}} c99-no-diagnostics +} aaron.ballman wrote: > You should spell out these diagnostics, and I think `c99-no

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

iana updated this revision to Diff 550121. iana marked 4 inline comments as done. iana added a comment. Review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157793/new/ https://reviews.llvm.org/D157793 Files: clang/lib/Headers/stdarg.h

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

aaron.ballman added a comment. In D157793#4585685 , @iana wrote: > In D157793#4585268 , @aaron.ballman > wrote: > >> In D157793#4583698 , @iana wrote: >> >>> In D157793#4

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

iana added a comment. In D157793#4585268 , @aaron.ballman wrote: > In D157793#4583698 , @iana wrote: > >> In D157793#4583663 , @MaskRay >> wrote: >> Apple needs a _

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

aaron.ballman added a comment. In D157793#4583698 , @iana wrote: > In D157793#4583663 , @MaskRay wrote: > >>> Apple needs a __need_ macro for va_list. Add one, and also ones for >>> va_start/va_arg/va_end, __va_c

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

iana added a comment. In D157793#4583663 , @MaskRay wrote: >> Apple needs a __need_ macro for va_list. Add one, and also ones for >> va_start/va_arg/va_end, __va_copy, va_copy. > > Do you have a link to the specification or the source that this is needed

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

MaskRay added a comment. > Apple needs a __need_ macro for va_list. Add one, and also ones for > va_start/va_arg/va_end, __va_copy, va_copy. Do you have a link to the specification or the source that this is needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

iana created this revision. iana added reviewers: zatrazz, jfb, MaskRay, eli.friedman, aaron.ballman, rsmith, steplong, efriedma, jyknight, erichkeane. Herald added a subscriber: ributzka. Herald added a project: All. iana requested review of this revision. Herald added a project: clang. Herald ad