[PATCH] D157580: [RISCV][NFC] Use named arguments in newly added changes

2023-08-10 Thread Wang Pengcheng via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2684f76204c: [RISCV][NFC] Use named arguments in newly added changes (authored by wangpc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D157580: [RISCV][NFC] Use named arguments in newly added changes

2023-08-09 Thread Alex Bradbury via Phabricator via cfe-commits
asb accepted this revision. asb added a comment. I just wanted to say thank you for your work on the named arguments tablegen feature. This and D154067 are good showcases of the readability improvement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D157580: [RISCV][NFC] Use named arguments in newly added changes

2023-08-09 Thread Brandon Wu via Phabricator via cfe-commits
4vtomat accepted this revision. 4vtomat added a comment. LGTM, thanks~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157580/new/ https://reviews.llvm.org/D157580 ___ cfe-commits mailing list cfe-commits@

[PATCH] D157580: [RISCV][NFC] Use named arguments in newly added changes

2023-08-09 Thread Wang Pengcheng via Phabricator via cfe-commits
wangpc created this revision. wangpc added reviewers: 4vtomat, craig.topper. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzhen