[PATCH] D157566: [SEH] fix assertion when -fasy-exceptions is used.

2023-08-10 Thread Jennifer Yu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG33e3b2c46084: Fix assertion when -fasy-exception is used. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157566/new/ https://reviews.llvm

[PATCH] D157566: [SEH] fix assertion when -fasy-exceptions is used.

2023-08-10 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 updated this revision to Diff 549174. jyu2 added a comment. Thanks all for the review! This is fix space problem. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157566/new/ https://reviews.llvm.org/D157566 Files: clang/lib/CodeGen/CGCleanup.cpp clang/test/CodeGen/windows-seh-a

[PATCH] D157566: [SEH] fix assertion when -fasy-exceptions is used.

2023-08-10 Thread Aaron Smith via Phabricator via cfe-commits
asmith accepted this revision. asmith added inline comments. Comment at: clang/test/CodeGen/windows-seh-async-exceptions.cpp:21 +{ +devif_Warning(""); +return 0; nit; spacing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D157566: [SEH] fix assertion when -fasy-exceptions is used.

2023-08-10 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157566/new/ https://reviews.llvm.org/D157566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D157566: [SEH] fix assertion when -fasy-exceptions is used.

2023-08-10 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157566/new/ https://reviews.llvm.org/D157566

[PATCH] D157566: [SEH] fix assertion when -fasy-exceptions is used.

2023-08-09 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 created this revision. jyu2 added reviewers: asmith, tentzen, rnk, efriedma, pengfei. jyu2 added a project: clang. Herald added a project: All. jyu2 requested review of this revision. The assertion only happens with use of -fasy-exception without -fexcessions. The assertion appen during the