This revision was automatically updated to reflect the committed changes.
Closed by commit rG33e3b2c46084: Fix assertion when -fasy-exception is used.
(authored by jyu2).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157566/new/
https://reviews.llvm
jyu2 updated this revision to Diff 549174.
jyu2 added a comment.
Thanks all for the review! This is fix space problem.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157566/new/
https://reviews.llvm.org/D157566
Files:
clang/lib/CodeGen/CGCleanup.cpp
clang/test/CodeGen/windows-seh-a
asmith accepted this revision.
asmith added inline comments.
Comment at: clang/test/CodeGen/windows-seh-async-exceptions.cpp:21
+{
+devif_Warning("");
+return 0;
nit; spacing
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
htt
rnk added a comment.
lgtm
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157566/new/
https://reviews.llvm.org/D157566
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157566/new/
https://reviews.llvm.org/D157566
jyu2 created this revision.
jyu2 added reviewers: asmith, tentzen, rnk, efriedma, pengfei.
jyu2 added a project: clang.
Herald added a project: All.
jyu2 requested review of this revision.
The assertion only happens with use of -fasy-exception without
-fexcessions.
The assertion appen during the