kfunk planned changes to this revision.
kfunk added a comment.
Marking this Diff properly -- it needs more work.
https://reviews.llvm.org/D15729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
realincubus added a comment.
would it be possible to add some cmake flag that would allow the user to choose
whether to respect the libclang.exports file or not ?
http://reviews.llvm.org/D15729
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
bkramer added a comment.
If we really want to go down this route we should drop the exports file,
putting random symbols in there is not going to fly. I'm not sure what that
would break for libclang users though.
Also make sure that your building without BUILD_SHARED_LIBS, otherwise you'll
get
realincubus added a comment.
@bkramer I can verify that after building this with clang 3.9 in release mode
it does not work anymore like expected. everything is fine in debug mode
if i look at the output generated from
llvm::sys::DynamicLibrary::LoadLibraryPermanently
in 1761 CompilerInstanc
bkramer accepted this revision.
bkramer added a comment.
This looks good, thanks for the patch. When this goes in please watch the
windows buildbots as plugin support on windows is somewhat broken and we may
have to disable tests there.
Also, while this is a strict improvement and should go in
kfunk updated this revision to Diff 50720.
kfunk added a comment.
Remove unrelated hunk
http://reviews.llvm.org/D15729
Files:
include/clang/Frontend/CompilerInstance.h
lib/Frontend/ASTUnit.cpp
lib/Frontend/CompilerInstance.cpp
lib/FrontendTool/ExecuteCompilerInvocation.cpp
unittests/F
kfunk added a comment.
@bkramer: Thoughts about my patch? I wonder if this makes your "work-around" in
http://reviews.llvm.org/D17808 redundant.
http://reviews.llvm.org/D15729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
kfunk added a comment.
Okay, just gave this another look. Unit test seems fine as-is. Let's call
`loadPlugins` there explicitly.
@LLVM/Clang devs: Please review!
I'm especially interested in whether you think there's a better location for
calling `CompilerInstance::loadPlugins` than in `ASTUni
kfunk updated this revision to Diff 4.
kfunk added a comment.
This revision is now accepted and ready to land.
Remove TODO statement
http://reviews.llvm.org/D15729
Files:
include/clang/Frontend/CompilerInstance.h
lib/Frontend/ASTUnit.cpp
lib/Frontend/CompilerInstance.cpp
lib/Fronten
milianw accepted this revision.
milianw added a reviewer: milianw.
milianw added a comment.
This revision is now accepted and ready to land.
Still good from my side. @klimek, @rsmith: Could you please review this as
well?
Thanks
http://reviews.llvm.org/D15729
__
kfunk planned changes to this revision.
kfunk added a comment.
Note: Unit test is still not functional. I'll have another look at it now.
http://reviews.llvm.org/D15729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
realincubus added a comment.
ok after i checked out a recent version of clang and applied the patch
http://reviews.llvm.org/D15729 i can verify, that one does not have to add the
symbols to the libclang.exports file.
i believe the plugin mechanism was changed between the first version of my
pl
kfunk added a comment.
@realincubus: Sorry, I didn't know you had put this up for review already.
So back to this patch. Yes, it works fine for me *without* amending
libclang.exports. I'm injecting the arguments to `clang_parseTranslationUnit2`.
See this patch here for reference:
https://quick
realincubus added a comment.
Hi.
I am finally back at work and happy to see that some effort already went into
the patch that i initially wrote some time ago (http://reviews.llvm.org/D5611)
I just looked through the files of the new patch and noticed that the
libclang.exports file is missing.
kfunk updated this revision to Diff 9.
kfunk added a comment.
Update, add (non-working) test
Just uploading my WIP patch, now that the branching comes close. I added a
test, unfortunately it doesn't do what I expect.
Please see the FIXME.
Didn't have the time to investigate yet, so any hint
doug.gregor added a comment.
It looks good. Are you able to include a test for this?
http://reviews.llvm.org/D15729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
milianw added a subscriber: milianw.
milianw added a comment.
lgtm, but someone else should approve
http://reviews.llvm.org/D15729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kfunk added a comment.
By the way; prove that it really works:
http://wstaw.org/m/2015/12/23/kdevelop-clazy.png (loving it!) :)
http://reviews.llvm.org/D15729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
kfunk added a comment.
Doing as requested by
http://lists.llvm.org/pipermail/cfe-dev/2014-October/039381.html, let's put
this up for review in its initial form, so we can discuss a better approach.
http://reviews.llvm.org/D15729
___
cfe-commits ma
19 matches
Mail list logo
