[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

2023-08-15 Thread Qiongsi Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG611ce24114aa: [PGO] Enable `-fprofile-update` for `-fprofile-generate` (authored by qiongsiwu1). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157280/new/ h

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

2023-08-14 Thread Qiongsi Wu via Phabricator via cfe-commits
qiongsiwu1 updated this revision to Diff 550067. qiongsiwu1 added a comment. Fixing method parameter name format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157280/new/ https://reviews.llvm.org/D157280 Files: clang/docs/UsersManual.rst clan

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

2023-08-14 Thread Qiongsi Wu via Phabricator via cfe-commits
qiongsiwu1 added inline comments. Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1797 addPGOInstrPasses(MPM, Level, /* RunProfileGen */ true, -/* IsCS */ true, PGOOpt->CSProfileGenFile, -PGOOpt->ProfileRemappingFile, +

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

2023-08-14 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1797 addPGOInstrPasses(MPM, Level, /* RunProfileGen */ true, -/* IsCS */ true, PGOOpt->CSProfileGenFile, -PGOOpt->ProfileRemappingFile, +

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

2023-08-14 Thread Qiongsi Wu via Phabricator via cfe-commits
qiongsiwu1 added a comment. In D157280#4586078 , @MaskRay wrote: > Please add a link to https://reviews.llvm.org/D87737 in the summary/commit > message. Will do! Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1797 addPGO

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

2023-08-14 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Please add a link to https://reviews.llvm.org/D87737 in the summary/commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157280/new/ https://reviews.llvm.org/D157280 __

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

2023-08-14 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1797 addPGOInstrPasses(MPM, Level, /* RunProfileGen */ true, -/* IsCS */ true, P

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

2023-08-14 Thread Qiongsi Wu via Phabricator via cfe-commits
qiongsiwu1 added a comment. Ping for review. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157280/new/ https://reviews.llvm.org/D157280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

2023-08-09 Thread Qiongsi Wu via Phabricator via cfe-commits
qiongsiwu1 updated this revision to Diff 548695. qiongsiwu1 added a comment. Update clang users manual. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157280/new/ https://reviews.llvm.org/D157280 Files: clang/docs/UsersManual.rst clang/lib/Code

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

2023-08-07 Thread Qiongsi Wu via Phabricator via cfe-commits
qiongsiwu1 created this revision. qiongsiwu1 added reviewers: MaskRay, davidxl, w2yehia. Herald added subscribers: wlei, ormris, wenlei, hiraditya. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,