[PATCH] D157188: [clang-tidy] Add bugprone-new-bool-conversion

2023-08-05 Thread Chandler Carruth via Phabricator via cfe-commits
chandlerc added a comment. In D157188#4563143 , @Eugene.Zelenko wrote: > In D157188#4563139 , @PiotrZSL > wrote: > >> In D157188#4563105 , >> @Eugene.Zelenko wrote: >>

[PATCH] D157188: [clang-tidy] Add bugprone-new-bool-conversion

2023-08-05 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. In D157188#4563139 , @PiotrZSL wrote: > In D157188#4563105 , > @Eugene.Zelenko wrote: > >> Shouldn't C-style allocation be checked too? Same for custom allocators via >> configura

[PATCH] D157188: [clang-tidy] Add bugprone-new-bool-conversion

2023-08-05 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added a comment. In D157188#4563105 , @Eugene.Zelenko wrote: > Shouldn't C-style allocation be checked too? Same for custom allocators via > configuration option. In theory it could, but in such case name of check would need to change... Rep

[PATCH] D157188: [clang-tidy] Add bugprone-new-bool-conversion

2023-08-05 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. Same for file, threads and other resources allocation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157188/new/ https://reviews.llvm.org/D157188 ___ cfe-commits mailing l

[PATCH] D157188: [clang-tidy] Add bugprone-new-bool-conversion

2023-08-05 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. Shouldn't C-style allocation be checked too? Same for custom allocators via configuration option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157188/new/ https://reviews.llvm.org/D157188 _

[PATCH] D157188: [clang-tidy] Add bugprone-new-bool-conversion

2023-08-05 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Detects cases where t