This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG39191c457715: [NFC][Clang] Fix static analyzer concerns
(authored by eandrews).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
eandrews updated this revision to Diff 554063.
eandrews added a comment.
Changed a dyn_cast to cast and handled ObjCAtFinallyStmt similar to how
ObjCAtTryStmt is handled, i.e. just check that it exists before calling
PrintRawCompoundStmt
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D15
tahonermann accepted this revision.
tahonermann added a comment.
I think this change is good as is, but I added some additional thoughts to
Aaron's earlier comment.
Comment at: clang/lib/AST/StmtPrinter.cpp:178
void StmtPrinter::PrintRawCompoundStmt(CompoundStmt *Node) {
+ a
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM though there may be some additional changes worth considering; I don't
insist on changes though.
Comment at: clang/lib/AST/StmtPrinter.cpp:178
void StmtP
eandrews created this revision.
eandrews added reviewers: aaron.ballman, tahonermann.
Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus,
a.sidorin, baloghadamsoftware.
Herald added a reviewer: NoQ.
Herald added a project: All.
eandrews requested review of this revision.
