[PATCH] D157090: [Flang][Sema] Move directive sets to a shared location

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGec70627dd177: [Flang][Sema] Move directive sets to a shared location (authored by skatrak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D157090: [Flang][Sema] Move directive sets to a shared location

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. Thanks. LG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157090/new/ https://reviews.llvm.org/D157090 __

[PATCH] D157090: [Flang][Sema] Move directive sets to a shared location

skatrak added a comment. In D157090#4562088 , @kiranchandramohan wrote: > This looks OK. The only concern is whether we will lose the ability to inline > the code for set membership. Can these sets be put in a header file with > `inline constexpr`? Th

[PATCH] D157090: [Flang][Sema] Move directive sets to a shared location

skatrak updated this revision to Diff 547686. skatrak added a comment. Declare sets as `inline` inside of header file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157090/new/ https://reviews.llvm.org/D157090 Files: clang/docs/tools/clang-forma

[PATCH] D157090: [Flang][Sema] Move directive sets to a shared location

kiranchandramohan added a comment. This looks OK. The only concern is whether we will lose the ability to inline the code for set membership. Can these sets be put in a header file with `inline constexpr`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D157090: [Flang][Sema] Move directive sets to a shared location

skatrak updated this revision to Diff 547181. skatrak added a comment. Add missing newline at end of file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157090/new/ https://reviews.llvm.org/D157090 Files: clang/docs/tools/clang-formatted-files.t

[PATCH] D157090: [Flang][Sema] Move directive sets to a shared location

skatrak created this revision. skatrak added reviewers: kiranchandramohan, jsjodin, domada, agozillon, TIFitis, raghavendhra. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. skatrak requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribe