ygao closed this revision.
ygao added a comment.
The test is commited in http://reviews.llvm.org/rL258898 and
http://reviews.llvm.org/rL258902, and it is enabled on buildbot in
http://reviews.llvm.org/rL259248.
Thanks!
http://reviews.llvm.org/D15705
_
On 25 January 2016 at 11:03, Yunzhong Gao
wrote:
> ygao added a comment.
>
> Thanks, Rafael!
> I did verify that the test would fail without my fix. But what do I need to
> do to make buildbots turn on the new lit parameter?
That I do not know. Mike?
Cheers,
Rafael
_
ygao added a comment.
Thanks, Rafael!
I did verify that the test would fail without my fix. But what do I need to do
to make buildbots turn on the new lit parameter?
http://reviews.llvm.org/D15705
___
cfe-commits mailing list
cfe-commits@lists.llvm
rafael accepted this revision.
rafael added a reviewer: rafael.
rafael added a comment.
This revision is now accepted and ready to land.
LGTM assuming you can get the test to fail by reverting the fix
http://reviews.llvm.org/D15705
___
cfe-commits m
ygao updated this revision to Diff 45784.
http://reviews.llvm.org/D15705
Files:
test/Preprocessor/bigoutput.c
test/lit.cfg
Index: test/lit.cfg
===
--- test/lit.cfg
+++ test/lit.cfg
@@ -491,4 +491,9 @@
if use_gmalloc:
conf
ygao updated this revision to Diff 44351.
http://reviews.llvm.org/D15705
Files:
test/Preprocessor/bigoutput.c
Index: test/Preprocessor/bigoutput.c
===
--- test/Preprocessor/bigoutput.c
+++ test/Preprocessor/bigoutput.c
@@ -0,0 +1,
ygao added a comment.
In llvm/utils/lit/lit/TestRunner.py line#202 inside function executeShCmd(),
the test is spawned by
subprocess.Popen(command, ..., stdout = subprocess.PIPE, stderr =
subprocess.PIPE, ...)
And the test passes. I can verify with a small python script doing just a
subprocess.
ygao added a comment.
> What I would suggest is:
>
> Check that this test fails at least on windows with your patch
>
> reverted. If so, commit it. BTW, don't you need to drop the "|
> FileCheck" to cause a crash?
Hmm, even with the pipe removed, I still have difficulty reproducing the
Gosh, that is quite unfortunate. The problems I see are
* The code only work on windows, as opening a file as text on other
systems is not special.
* There is a confusion in the code about binary being "crlf
translation" or "produce a .o". The logic for creating a buffer is
there because the .o wr
ygao added a comment.
If you take a look at
void PrintPreprocessedAction::ExecuteAction() {
...
while (next < end) {
if (*cur == 0x0D) { // CR
if (*next == 0x0A) // CRLF
BinaryMode = false;
...
The value of this BinaryMode reflects whethe
Are you sure the line ending in a problem? The preprocessor output has
16 lines, but the last one is very long.
In any case, it looks like at least on linux clang produces an output
with '\n' even when the input has CRLF:
$ file test.c
test.c: ASCII text, with CRLF line terminators
$ clang -E tes
ygao updated this revision to Diff 43554.
ygao added a comment.
I think what I can do is to run
svn propset svn:eol-style 'LF'
on the new file, and hopefully the subversion or git client will get the hint
and not auto-translate the line endings.
http://reviews.llvm.org/D15705
Files:
test/Pre
ygao added a comment.
Hi Rafael,
Yes I can do that, and it works for me. Do you know whether there is a way to
keep the UNIX line ending on the test file upon checkout rather than having svn
or git auto-translate the line endings? The UNIX line ending is necessary to
trigger the original bug,
Can't you use the preprocessor to produce a large output? See the
testcase in https://llvm.org/bugs/show_bug.cgi?id=10651#c10 for
example.
Cheers,
Rafael
On 21 December 2015 at 20:07, Yunzhong Gao via cfe-commits
wrote:
> ygao created this revision.
> ygao added subscribers: cfe-commits, rsandi
ygao added inline comments.
Comment at: test/Preprocessor/bigoutput.py:7
@@ +6,3 @@
+
+f = open("bigoutput.c", "wb")
+for i in range(0, 15000):
For example, it would be nice to use %t as the temporary file name (so lit will
fill in with a generated
name) instead
ygao created this revision.
ygao added subscribers: cfe-commits, rsandifo, majnemer, aaron.ballman.
Hi,
I am trying to add a test for PR25717. The test itself is fairly
straight-forward: it generates a
large .c temporary file on the fly and then runs the preprocessor over the
generated file to
m
16 matches
Mail list logo
