[PATCH] D157035: [clang][cli] Accept option spelling as `Twine`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG243bc7504965: [clang][cli] Accept option spelling as `Twine` (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D157035: [clang][cli] Accept option spelling as `Twine`

jansvoboda11 added a comment. That's a good point. Updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157035/new/ https://reviews.llvm.org/D157035 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D157035: [clang][cli] Accept option spelling as `Twine`

jansvoboda11 updated this revision to Diff 547014. jansvoboda11 added a comment. Assert that spelling is null-terminated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157035/new/ https://reviews.llvm.org/D157035 Files: clang/lib/Frontend/Compile

[PATCH] D157035: [clang][cli] Accept option spelling as `Twine`

benlangmuir added a comment. This code asserts that the Twine is a single stringref, but it's also relying on the fact it's null-terminated; can we check for that as well, or at least document it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1570

[PATCH] D157035: [clang][cli] Accept option spelling as `Twine`

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This will make it possible to acc