[PATCH] D157029: [llvm] Construct option spelling at compile-time

2023-08-04 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 547298. jansvoboda11 added a comment. Improve `Option::getPrefixedName()` instead of introducing new `Option::getSpelling()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157029/new/ https://reviews.llvm

[PATCH] D157029: [llvm] Construct option spelling at compile-time

2023-08-04 Thread Ben Langmuir via Phabricator via cfe-commits
benlangmuir added inline comments. Comment at: llvm/include/llvm/Option/Option.h:103 + StringLiteral getSpelling() const { +assert(Info && "Must have a valid info!"); This could use a doc comment to differentiate it from other string representations. How

[PATCH] D157029: [llvm] Construct option spelling at compile-time

2023-08-03 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 547019. jansvoboda11 added a comment. Rebase on top of D157028 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157029/new/ https://reviews.llvm.org/D157029 Files: clang

[PATCH] D157029: [llvm] Construct option spelling at compile-time

2023-08-03 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 created this revision. jansvoboda11 added a reviewer: MaskRay. Herald added subscribers: ormris, ributzka, kadircet, arphaman, hiraditya. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: jhenderson. Herald added a project: All. jansvoboda11 requested review of