aeubanks added inline comments.
Comment at: llvm/test/CodeGen/AArch64/stack-guard-sysreg.ll:1
-; RUN: split-file %s %t
; RUN: cat %t/main.ll %t/a.ll > %t/a2.ll
; RUN: cat %t/main.ll %t/b.ll > %t/b2.ll
this test is broken, without the `split-file` the other file
harviniriawan updated this revision to Diff 551978.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156799/new/
https://reviews.llvm.org/D156799
Files:
clang/test/CodeGen/aarch64-ABI-align-packed-assembly.c
llvm/lib/Target/AArch64/AArch64.td
llv
harviniriawan updated this revision to Diff 551953.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156799/new/
https://reviews.llvm.org/D156799
Files:
clang/test/CodeGen/aarch64-ABI-align-packed-assembly.c
llvm/lib/Target/AArch64/AArch64.td
llv
harviniriawan updated this revision to Diff 551951.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156799/new/
https://reviews.llvm.org/D156799
Files:
clang/test/CodeGen/aarch64-ABI-align-packed-assembly.c
llvm/lib/Target/AArch64/AArch64.td
llv
dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.
Thanks. Looks good. You may need to rebase over new tests, make sure everything
is still passing when you do.
LGTM
Comment at: llvm/test/CodeGen/AArch64/misched-detail-re
harviniriawan added inline comments.
Comment at: llvm/test/CodeGen/AArch64/stack-guard-sysreg.ll:1
-; RUN: split-file %s %t
; RUN: cat %t/main.ll %t/a.ll > %t/a2.ll
; RUN: cat %t/main.ll %t/b.ll > %t/b2.ll
dmgreen wrote:
> Can you explain this one? Are the two
harviniriawan updated this revision to Diff 546884.
harviniriawan marked 23 inline comments as done.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156799/new/
https://reviews.llvm