vsk accepted this revision.
vsk added a reviewer: vsk.
vsk added a comment.
This revision is now accepted and ready to land.
Closing old review.
http://reviews.llvm.org/D15674
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
vsk added a comment.
Thanks for the review. Committed r256185
http://reviews.llvm.org/D15674
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
Thank you, that's great. LGTM.
http://reviews.llvm.org/D15674
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk updated this revision to Diff 43384.
vsk added a comment.
- Update patch according to John's comments.
http://reviews.llvm.org/D15674
Files:
lib/CodeGen/CGObjCMac.cpp
lib/CodeGen/CGObjCRuntime.h
test/CodeGenObjCXX/blocks.mm
Index: test/CodeGenObjCXX/blocks.mm
rjmccall added a comment.
You don't need a CodeGenFunction for this; just use
llvm::ConstantExpr::getBitCast. Please document the requirement that this
returns an i8* in CGObjCRuntime.h.
http://reviews.llvm.org/D15674
___
cfe-commits mailing list
vsk created this revision.
vsk added a reviewer: rjmccall.
vsk added a subscriber: cfe-commits.
[CodeGen] Fix assignments of inline layouts into the byref structure
When using blocks, a byref structure is created to represent the
closure. The "byref.layout" field of this structure is an i8*. Howe
