This revision was automatically updated to reflect the committed changes.
Closed by commit rL258530: [MSVC Compat] Accept elided commas in macro function
arguments (authored by ehsan).
Changed prior to commit:
http://reviews.llvm.org/D15670?vs=43310&id=45718#toc
Repository:
rL LLVM
http://r
ehsan added a comment.
Sure. I'd be happy to address any comments post-landing.
Thanks!
http://reviews.llvm.org/D15670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sure. I'd be happy to address any comments post-landing.
Thanks!
On Fri, Jan 22, 2016 at 2:13 PM, Reid Kleckner wrote:
> rnk added a comment.
>
> Let's go ahead and land this. It doesn't seem high risk. Richard will be
> back on Monday, he's been skiing.
>
>
> http://reviews.llvm.org/D15670
>
rnk added a comment.
Let's go ahead and land this. It doesn't seem high risk. Richard will be back
on Monday, he's been skiing.
http://reviews.llvm.org/D15670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
ehsan added a subscriber: ehsan.
ehsan added a comment.
Richard: ping?
http://reviews.llvm.org/D15670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Richard: ping?
On Tue, Jan 12, 2016 at 6:41 PM, Reid Kleckner wrote:
> rnk accepted this revision.
> rnk added a comment.
> This revision is now accepted and ready to land.
>
> Seems reasonable to me, but we should check with Richard.
>
>
> http://reviews.llvm.org/D15670
>
>
>
>
--
Ehsan
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Seems reasonable to me, but we should check with Richard.
http://reviews.llvm.org/D15670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
ehsan created this revision.
ehsan added reviewers: rnk, rsmith.
ehsan added a subscriber: cfe-commits.
This fixes PR25875. When the trailing comma in a macro argument list is
elided, we need to treat it similarly to the case where a variadic macro
misses one actual argument.
http://reviews.llvm
