cor3ntin added inline comments.
Comment at: llvm/utils/UnicodeData/UnicodeNameMappingGenerator.cpp:100
+for (auto ChIt = Name.begin(); ChIt != Name.end();
+ ChIt += IsBeforeMedial ? 3 : 1) {
+ char Ch = *ChIt;
aaron.ballman wrote:
> Parens here m
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG68410fbed769: Fix handling of medial hyphens in Unicode
Names. (authored by cor3ntin).
Changed prior to commit:
https://reviews.llvm.org/D156518?v
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: llvm/utils/UnicodeData/UnicodeNameMappingGenerator.cpp:100
+for (auto ChIt = Name.begin(); ChIt != Name.end();
+ ChIt += IsBeforeMe
cor3ntin updated this revision to Diff 545078.
cor3ntin added a comment.
Fix comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156518/new/
https://reviews.llvm.org/D156518
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Lex/LiteralSupport.cpp
tbaeder added inline comments.
Comment at: llvm/lib/Support/UnicodeNameToCodepoint.cpp:350
bool DoesStartWith = startsWith(Name, Item.Prefix, Strict, Consummed,
-NameStart, NeedleStart, /*isPrefix*/ true);
+
cor3ntin created this revision.
Herald added subscribers: mstorsjo, hiraditya, dschuff.
Herald added a project: All.
cor3ntin requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
In a Unicode name was stored in a way that cause
