[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG87461d669684: [clang][Interp] Implement __builtin_offsetof (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D156400?vs=556

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM, thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156400/new/ https://reviews.llvm.org/D156400 ___ cfe-commits mailing list c

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

tbaeder updated this revision to Diff 556339. tbaeder marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156400/new/ https://reviews.llvm.org/D156400 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/In

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

cor3ntin added a comment. Generally looks good but still a few unaddressed comments Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1536-1537 + // Cast to Sint64. + if (IndexT != PT_Sint64) { +if (!this->emitCast(IndexT, PT_Sint64, E)) + return f

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156400/new/ https://reviews.llvm.org/D156400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156400/new/ https://reviews.llvm.org/D156400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1536-1537 + // Cast to Sint64. + if (IndexT != PT_Sint64) { +if (!this->emitCast(IndexT, PT_Sint64, E)) + return false; cor3ntin wrote: > Shouldn't that

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

cor3ntin added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1902 + std::vector ArrayIndices; + for (unsigned I = 0; I != E->getNumExpressions(); ++I) +ArrayIndices.emplace_back(S.Stk.pop()); can you use size_t here? It's already a bug nest but

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

cor3ntin added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1536-1537 + // Cast to Sint64. + if (IndexT != PT_Sint64) { +if (!this->emitCast(IndexT, PT_Sint64, E)) + return false; Shouldn't that be size_t? CHA

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

cor3ntin added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1901 +inline bool OffsetOf(InterpState &S, CodePtr OpPC, const OffsetOfExpr *E) { + std::vector ArrayIndices; + for (unsigned I = 0; I != E->getNumExpressions(); ++I) Might be useful to u

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

tbaeder updated this revision to Diff 544823. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156400/new/ https://reviews.llvm.org/D156400 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Inter

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

tbaeder updated this revision to Diff 544693. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156400/new/ https://reviews.llvm.org/D156400 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Inter

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Put all the index expressions on the stack and cast th