[PATCH] D156344: Disable call to fma for soft-float

2023-09-28 Thread Kishan Parmar via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG696ea67f197f: Disable call to fma for soft-float (authored by long5hot). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D156344: Disable call to fma for soft-float

2023-09-27 Thread Kishan Parmar via Phabricator via cfe-commits
long5hot added a comment. landing on this PR, from the conclusion of #55230 and D158632 conversation.. "If the llvm.fmuladd intrinsic reaches the backend, the backend is responsible for deciding how to repres

[PATCH] D156344: Disable call to fma for soft-float

2023-09-25 Thread Kishan Parmar via Phabricator via cfe-commits
long5hot added a comment. ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156344/new/ https://reviews.llvm.org/D156344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156344: Disable call to fma for soft-float

2023-08-24 Thread Kishan Parmar via Phabricator via cfe-commits
long5hot added a comment. @nemanjai , @jhibbits should i land on this commit, because as @shchenz said, similiar to D158632 review we are having plan to do same for PPC. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156344/new/ https://reviews.llvm

[PATCH] D156344: Disable call to fma for soft-float

2023-08-15 Thread ChenZheng via Phabricator via cfe-commits
shchenz added a comment. In D156344#4583767 , @long5hot wrote: > In D156344#4583559 , @shchenz wrote: > >> compiler-rt builtins library should not just undefining fma for PPC, right >> (see >> https://gcc.gnu.or

[PATCH] D156344: Disable call to fma for soft-float

2023-08-13 Thread Kishan Parmar via Phabricator via cfe-commits
long5hot added a comment. In D156344#4583559 , @shchenz wrote: > compiler-rt builtins library should not just undefining fma for PPC, right > (see https://gcc.gnu.org/onlinedocs/gccint/Soft-float-library-routines.html)? > If so, maybe we should at least

[PATCH] D156344: Disable call to fma for soft-float

2023-08-13 Thread ChenZheng via Phabricator via cfe-commits
shchenz added a comment. compiler-rt builtins library should not just undefining fma for PPC, right (see https://gcc.gnu.org/onlinedocs/gccint/Soft-float-library-routines.html)? If so, maybe we should at least first try not generating fma for soft-float at the first place where fmul + fadd is f

[PATCH] D156344: Disable call to fma for soft-float

2023-07-26 Thread Kishan Parmar via Phabricator via cfe-commits
long5hot added a comment. Apologies for updating diff too many times, used arcanist first time. Won't happend again! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156344/new/ https://reviews.llvm.org/D156344 ___ cfe-commits mailing list cfe-

[PATCH] D156344: Disable call to fma for soft-float

2023-07-26 Thread Kishan Parmar via Phabricator via cfe-commits
long5hot updated this revision to Diff 544438. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156344/new/ https://reviews.llvm.org/D156344 Files: llvm/lib/Target/PowerPC/PPCISelLowering.cpp llvm/test/CodeGen/PowerPC/ppcsoftops.ll Index: llvm/test/CodeGen/PowerPC/ppcsoftops.ll ==

[PATCH] D156344: Disable call to fma for soft-float

2023-07-26 Thread Kishan Parmar via Phabricator via cfe-commits
long5hot updated this revision to Diff 544437. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156344/new/ https://reviews.llvm.org/D156344 Files: llvm/lib/Target/PowerPC/PPCISelLowering.cpp llvm/test/CodeGen/PowerPC/ppcsoftops.ll llvm/utils/gn/secondary/llvm/tools/sancov/BUILD.gn

[PATCH] D156344: Disable call to fma for soft-float

2023-07-26 Thread Kishan Parmar via Phabricator via cfe-commits
long5hot updated this revision to Diff 544432. long5hot added a comment. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. After clang release/16.x there is a regression that -mabi=elfv1 or -mabi=elfv2 are being unused and throws warning. But clang-trunk throws error f