[PATCH] D156205: wasm: link crt1 even in case of -shared

This revision was automatically updated to reflect the committed changes. Closed by commit rG989ce069a463: [clang][WebAssembly] Link crt1 even in case of -shared (authored by yamt, committed by sbc100). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D156205: wasm: link crt1 even in case of -shared

yamt marked an inline comment as done. yamt added a comment. can this land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156205/new/ https://reviews.llvm.org/D156205 ___ cfe-commits mailing list cfe-com

[PATCH] D156205: wasm: link crt1 even in case of -shared

yamt added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:80 - const char *Crt1 = "crt1.o"; + bool isCommand = true; + const char *Crt1; sbc100 wrote: > LLCM coding style is `IsCommand` (at last for now: > https://llvm.org/docs/Pro

[PATCH] D156205: wasm: link crt1 even in case of -shared

yamt updated this revision to Diff 546525. yamt added a comment. isCommand -> IsCommand Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156205/new/ https://reviews.llvm.org/D156205 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/test/Dr

[PATCH] D156205: wasm: link crt1 even in case of -shared

sbc100 accepted this revision. sbc100 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:80 - const char *Crt1 = "crt1.o"; + bool isCommand = true; + const char *Crt1; LLCM coding s

[PATCH] D156205: wasm: link crt1 even in case of -shared

yamt updated this revision to Diff 546417. yamt added a comment. when -shared, use the reactor model by default Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156205/new/ https://reviews.llvm.org/D156205 Files: clang/lib/Driver/ToolChains/WebAsse

[PATCH] D156205: wasm: link crt1 even in case of -shared

yamt updated this revision to Diff 544275. yamt added a comment. update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156205/new/ https://reviews.llvm.org/D156205 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/test/Driver/wasm-t

[PATCH] D156205: wasm: link crt1 even in case of -shared

yamt added a comment. > Should -shared modules also link with crt1-reactor.o by default then? Or > should we add crt1-shared.o and use the whenever -shared is passed. Should we > also make -shared incompatible with -mexec-model? It seems like -mexec-model > should only apply to the main module,

[PATCH] D156205: wasm: link crt1 even in case of -shared

sbc100 added a comment. I think we are vearing into somewhat uncharted territory here, but we should probably push forward and document the direction we choose. Should `-shared` modules also link with `crt1-reactor.o` by default then? Or should we add `crt1-shared.o` and use the whenever `-sh

[PATCH] D156205: wasm: link crt1 even in case of -shared

yamt created this revision. Herald added subscribers: pmatos, asb, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: All. yamt requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, aheejin. Herald added a project: clang. This allows -mexec-model=reac