[PATCH] D156127: Partially revert changes to test lang-std.cpp

yaxunl closed this revision. yaxunl added a comment. committed by 19d3b37196553372e963bd70718bba1b0bfc94ee CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156127/new/ https://reviews.llvm.org/D156127 _

[PATCH] D156127: Partially revert changes to test lang-std.cpp

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156127/new/ https://reviews.llvm.org/D156127 ___ cfe-commits mailing list cfe-com

[PATCH] D156127: Partially revert changes to test lang-std.cpp

yaxunl updated this revision to Diff 543671. yaxunl added a comment. fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156127/new/ https://reviews.llvm.org/D156127 Files: clang/test/Preprocessor/lang-std.cpp Index: clang/test/Preprocessor/lang-std.cpp =

[PATCH] D156127: Partially revert changes to test lang-std.cpp

yaxunl updated this revision to Diff 543670. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156127/new/ https://reviews.llvm.org/D156127 Files: clang/test/Preprocessor/lang-std.cpp Index: clang/test/Preprocessor/lang-std.cpp ==

[PATCH] D156127: Partially revert changes to test lang-std.cpp

probinson added inline comments. Comment at: clang/test/Preprocessor/lang-std.cpp:4 // RUN: %clang_cc1 -dM -E %s | grep __cplusplus >%T-cpp-std.txt +// RUN: cat %T-cpp-std.txt | FileCheck --check-prefix=CXX17 %s + Use `--input-file` and there's one fewer process

[PATCH] D156127: Partially revert changes to test lang-std.cpp

yaxunl updated this revision to Diff 543640. yaxunl marked an inline comment as done. yaxunl added a reviewer: dyung. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156127/new/ https://reviews.llvm.org/D156127 Files: clang/test/Preprocessor/

[PATCH] D156127: Partially revert changes to test lang-std.cpp

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/Preprocessor/lang-std.cpp:1 +// UNSUPPORTED: target={{.*-(ps4|ps5)}} /// Test default standards. dyung wrote: > This should be unneeded now, we recently updated the PS

[PATCH] D156127: Partially revert changes to test lang-std.cpp

dyung added inline comments. Comment at: clang/test/Preprocessor/lang-std.cpp:1 +// UNSUPPORTED: target={{.*-(ps4|ps5)}} /// Test default standards. This should be unneeded now, we recently updated the PS platforms to default to c++17 like the rest of the compi

[PATCH] D156127: Partially revert changes to test lang-std.cpp

yaxunl created this revision. yaxunl added a reviewer: probinson. Herald added a project: All. yaxunl requested review of this revision. Recover the checking for the default language standard for C++. https://reviews.llvm.org/D156127 Files: clang/test/Preprocessor/lang-std.cpp Index: clang/