[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

cor3ntin added a comment. @aaron.ballman that's been waiting for a while - i don't feel comfortable reviewing it, mind looking at it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156057/new/ https://reviews.llvm.org/D156057 ___ cfe-commits

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

rZhBoYao updated this revision to Diff 543559. rZhBoYao added a comment. Refactor VisitCXXOperatorCallExpr and mark CWG2571 as done in Clang 15 (deliberately the same version P2128R6 was implemented) since this patch only fix the diagnostics around it. CHANGES SINCE LAST ACTION https://revie

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

rZhBoYao added a comment. Thanks for the reminder. I am aware of that. Browsing through 762672a73a1e and a560ccf2af7a , I believe the indeterminately sequenced requirement is met

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

Endill added a comment. In D156057#4527787 , @rZhBoYao wrote: > BTW, I am not sure if CWG2571 is implemented by > @cor3ntin? If so, can we mark it as done on > https://clang.llvm.org/cxx_dr_status.html#2571? This patch handles

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

rZhBoYao added a subscriber: cor3ntin. rZhBoYao added a comment. BTW, I am not sure if CWG2571 is implemented by @cor3ntin? If so, can we mark it as done on https://clang.llvm.org/cxx_dr_status.html#2571? This patch handles the warning around it tho. CHANGES SINCE L

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

rZhBoYao updated this revision to Diff 543315. rZhBoYao marked an inline comment as done. rZhBoYao added a comment. Improve the test. Not sure what the lack of C++17 checks was referring to in your conversation with Aaron. Can @aaron.ballman confirm whether it is addressed by this patch? CHANG

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

Endill added a comment. I'm sorry for hand-waving, but I also remember @aaron.ballman saying that code related to `-Wunsequenced` or around it was missing checks for C++17. I can't say whether you addressed that or not, so just leaving it here for you and reviewers. CHANGES SINCE LAST ACTION

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

Endill added a comment. Thank you for working on this! Comment at: clang/test/SemaCXX/warn-unsequenced.cpp:3 // RUN:-Wunsequenced -Wno-c++17-extensions -Wno-c++14-extensions %s -// RUN: %clang_cc1 -fsyntax-only -verify=cxx17 -std=c++17 -Wno-unused -Wno-uninitializ

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

rZhBoYao updated this revision to Diff 543295. rZhBoYao added a comment. Put `-Windeterminately-sequenced` under `-Wsequence-point`'s control CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156057/new/ https://reviews.llvm.org/D156057 Files: clang/docs/ReleaseNotes.rst clang/include/

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

rZhBoYao created this revision. rZhBoYao added reviewers: aaron.ballman, Endill, clang-language-wg. Herald added a project: All. rZhBoYao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add -Windeterminately-sequenced and fix -Wunsequenced