[PATCH] D155808: [clang][driver] Missing the condition in IsARMBigEndain function.

2023-07-24 Thread Simi Pallipurath via Phabricator via cfe-commits
simpal01 updated this revision to Diff 543484. simpal01 added a comment. Addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155808/new/ https://reviews.llvm.org/D155808 Files: clang/lib/Driver/ToolChains/BareMetal.cpp cl

[PATCH] D155808: [clang][driver] Missing the condition in IsARMBigEndain function.

2023-07-20 Thread Peter Smith via Phabricator via cfe-commits
peter.smith added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:39 // normalized triple so we must handle the flag here. bool arm::isARMBigEndian(const llvm::Triple &Triple, const ArgList &Args) { + if ((Triple.getArch() == llvm::Triple::arm ||

[PATCH] D155808: [clang][driver] Missing the condition in ISARMBigEndain function.

2023-07-20 Thread Simi Pallipurath via Phabricator via cfe-commits
simpal01 created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. simpal01 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. IsARMBIgEndian function returns true only if: 1. The triples are either