[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

tbaeder closed this revision. tbaeder added a comment. This landed as 673ef8ceaece6c9a7194474ef7d97b3b240c0dc5 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155568/new/ https://

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

tbaeder added a comment. In D155568#4596497 , @vitalybuka wrote: > Breaks the bot > https://lab.llvm.org/buildbot/#/builders/74/builds/21336/steps/13/logs/stdio > > Please take a look or revert? > > Note: msan_track_origins step may have useful details.

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

vitalybuka added a comment. Breaks the bot https://lab.llvm.org/buildbot/#/builders/74/builds/21336/steps/13/logs/stdio Please take a look or revert? Note: msan_track_origins step may have useful details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91af0d0a6698: [clang][Interp] Make sure we push integers of the correct size (authored by tbaeder). Changed prior to commit: https://reviews.llvm.

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

tbaeder added a comment. In D155568#4542764 , @aaron.ballman wrote: > In D155568#4525488 , @tbaeder wrote: > >> This patch is missing the `Ret` part in `InterpBuiltin()` in the >> same file. That needs to change

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

tbaeder updated this revision to Diff 545349. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155568/new/ https://reviews.llvm.org/D155568 Files: clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/InterpBuiltin.cpp clang/test/AST/Interp/builtin-functions.cpp Index: clang/test/AST/

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

aaron.ballman added a comment. In D155568#4525488 , @tbaeder wrote: > This patch is missing the `Ret` part in `InterpBuiltin()` in the > same file. That needs to change to the correct type as well. > > I can do that in a follow-up commit. @aaron.ballman

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

tbaeder updated this revision to Diff 543321. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155568/new/ https://reviews.llvm.org/D155568 Files: clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/InterpBuiltin.cpp Index: clang/lib/AST/Interp/InterpBuiltin.cpp ==

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

tbaeder updated this revision to Diff 543320. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155568/new/ https://reviews.llvm.org/D155568 Files: clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/InterpBuiltin.cpp Index: clang/lib/AST/Interp/InterpBuiltin.cpp ==

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

tbaeder added a comment. This patch is missing the `Ret` part in `InterpBuiltin()` in the same file. That needs to change to the correct type as well. I can do that in a follow-up commit. @aaron.ballman Can you come up with a value I can pass to `-triple` so I can actually test that this works?

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:36 +/// Pushes \p Val to the stack, as a target-dependent 'int'. +static void pushInt(InterpState &S, int32_t Val) { + const TargetInfo &TI = S.getCtx().getTargetInfo(); aaron.ball

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM as far as the changes go, but did have a question about whether we need this for unsigned values as well. Comment at: clang/lib/AST/Interp/InterpBuiltin.c

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Integers might not be 32 bits wide, so check the Tar