[PATCH] D155548: [clang][ExprConst] Short-circuit ConstantExpr evaluation

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4343aba9fa1: [clang][ExprConst] Short-circuit ConstantExpr evaluation (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155548/new/ http

[PATCH] D155548: [clang][ExprConst] Short-circuit ConstantExpr evaluation

aaron.ballman accepted this revision. aaron.ballman added a comment. In D155548#4653363 , @cor3ntin wrote: > @aaron.ballman Given the recent discussion we had on both github > (https://github.com/llvm/llvm-project/pull/66203) and privately, I'm going to

[PATCH] D155548: [clang][ExprConst] Short-circuit ConstantExpr evaluation

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. @aaron.ballman Given the recent discussion we had on both github (https://github.com/llvm/llvm-project/pull/66203) and privately, I'm going to accept that. We only create ConstantExpr for

[PATCH] D155548: [clang][ExprConst] Short-circuit ConstantExpr evaluation

aaron.ballman added a comment. I think the changes make sense and generally look good, but because this is intended as a performance improvement, I'd like some measurements to prove it actually does improve performance. That then gives us something good to talk about in a release note as well.

[PATCH] D155548: [clang][ExprConst] Short-circuit ConstantExpr evaluation

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155548/new/ https://reviews.llvm.org/D155548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D155548: [clang][ExprConst] Short-circuit ConstantExpr evaluation

tbaeder added a comment. In D155548#4509056 , @cor3ntin wrote: > I think this does make sense. Have you notice an impact on performance? No, but my local builds are debug builds and I have sanitizers enabled. When compiling the sqlite amalgamation, I se

[PATCH] D155548: [clang][ExprConst] Short-circuit ConstantExpr evaluation

cor3ntin added a comment. I think this does make sense. Have you notice an impact on performance? I wonder if there are places where we should cache the result of evaluating a ConstantExpr, like in `ExprEvaluatorBase::VisitConstantExpr` How often do we construct a ConstantExpr without an initial

[PATCH] D155548: [clang][ExprConst] Short-circuit ConstantExpr evaluation

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I think this makes sense to do, given that the `Consta