This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8a25145058d2: [clang][Interp] Pass CallExpr to builtin
functions (authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/D155545?
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155545/new/
https://reviews.llvm.org/D155545
___
cfe-commits mailing lis
tbaeder added a comment.
Ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155545/new/
https://reviews.llvm.org/D155545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaeder updated this revision to Diff 541834.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155545/new/
https://reviews.llvm.org/D155545
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/Interp.h
clang/lib/AST/Interp/InterpBuiltin.cpp
clang/lib/AST/Interp/Opcod
aaron.ballman added inline comments.
Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:78-79
+
+ if (!isa(Call->getArg(0)->IgnoreParenCasts()))
+return false;
+
Hmmm, I think I missed a situation when we were talking about this. Consider:
https://godbolt.o
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
For some builtins, we need to do quite a bit of type
