[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

owenpan requested changes to this revision. owenpan added a comment. This revision now requires changes to proceed. In D155529#4509686 , @MyDeveloperDay wrote: > We should never make assumptions about what people do/don't use > If you have this you ha

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare updated this revision to Diff 558064. gedare added a comment. Rebase to main. Fix up use of TT_AttributeParen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155529/new/ https://reviews.llvm.org/D155529 Files: clang/docs/ClangFormatStyleOp

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare updated this revision to Diff 544466. gedare added a comment. Rebase to 18 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155529/new/ https://reviews.llvm.org/D155529 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare updated this revision to Diff 543729. gedare added a comment. Add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155529/new/ https://reviews.llvm.org/D155529 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/Releas

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare updated this revision to Diff 542655. gedare added a comment. Add missing parser check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155529/new/ https://reviews.llvm.org/D155529 Files: clang/docs/ClangFormatStyleOptions.rst clang/inclu

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Format/ConfigParseTest.cpp:220 CHECK_PARSE_NESTED_BOOL(SpaceBeforeParensOptions, BeforeNonEmptyParentheses); + CHE

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare updated this revision to Diff 542651. gedare added a comment. Add one more attribute test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155529/new/ https://reviews.llvm.org/D155529 Files: clang/docs/ClangFormatStyleOptions.rst clang/in

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare updated this revision to Diff 542650. gedare added a comment. Rebase onto D155239 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155529/new/ https://reviews.llvm.org/D155529 Files: clang/docs/ClangFormat

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare updated this revision to Diff 542254. gedare added a comment. remove blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155529/new/ https://reviews.llvm.org/D155529 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare updated this revision to Diff 542253. gedare added a comment. Rebase onto D155239 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155529/new/ https://reviews.llvm.org/D155529 Files: clang/docs/ClangFormat

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare updated this revision to Diff 542090. gedare added a comment. Rebase onto D155239 and correctly handle deprecated SpacesInParentheses option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155529/new/ https

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare planned changes to this revision. gedare added a comment. I need to fix this to reflect the changes in the parent rev. Comment at: clang/include/clang/Format/Format.h:4208-4213 +/// Put a space in parentheses inside attribute specifier lists. +/// \code +///

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

MyDeveloperDay added a comment. We should never make assumptions about what people do/don't use F28299562: image.png If you have this you have to honour it.. if 'SpacesInParentheses ' was true then 'InAttributeSpecifiers' needs to be true by default, shouldn

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:4208-4213 +/// Put a space in parentheses inside attribute specifier lists. +/// \code +///true: false: +///__attribute__(( noreturn

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

MyDeveloperDay added a comment. We should never make assumptions about what people do/don't use F28299562: image.png If you have this you have to honour it.. if 'SpacesInParentheses ' was true then 'InAttributeSpecifiers' needs to be true by default, shouldn

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare marked an inline comment as done. gedare added a comment. I simplified this to treat the double parens identically, so that it will either inject spaces inside both parens, or not. Note: This option is necessary to disable ``SpacesInParens.Other`` from adding spaces inside of ``__attribu

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare updated this revision to Diff 541322. gedare added a comment. Merge the two options to just one for attribute parens. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155529/new/ https://reviews.llvm.org/D155529 Files: clang/docs/ClangFormat

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare planned changes to this revision. gedare added inline comments. Comment at: clang/include/clang/Format/Format.h:4208-4213 +/// Put a space in parentheses inside attribute specifier lists. +/// \code +///true: false: +///

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

owenpan added inline comments. Comment at: clang/include/clang/Format/Format.h:4208-4213 +/// Put a space in parentheses inside attribute specifier lists. +/// \code +///true: false: +///__attribute__(( noreturn ))vs.

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

owenpan added inline comments. Comment at: clang/include/clang/Format/Format.h:4214-4220 +/// Put a space in parentheses around the outside of attribute specifier +/// lists. +/// \code +///true: false: +///__attribute_

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. gedare requested review of this revision. The __attribute((specifier-list)) currently is formatted bas