[PATCH] D155452: [Flang] Add support for fsave-optimization-record

This revision was automatically updated to reflect the committed changes. Closed by commit rGf04ccadf3544: [Flang] Add support for fsave-optimization-record (authored by Victor Kingi , committed by kiranchandramohan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 544277. victorkingi added a comment. rebasing no changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/ https://reviews.llvm.org/D155452 Files: clang/include/clang/Driver/Options.td clang/li

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi added inline comments. Comment at: flang/test/Driver/frontend-forwarding.f90:26 +! RUN: %flang -### %s 2>&1 \ +! RUN: -foptimization-record-file=%t.opt.yaml \ awarzynski wrote: > victorkingi wrote: > > awarzynski wrote: > > > Is a dedicated driv

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 543945. victorkingi added a comment. moved opt_record flags generation test from frontend-forwarding.f90 to fsave-optimization-record.f90 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/ https://re

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

awarzynski accepted this revision. awarzynski added a comment. LGTM, thanks for the updates! (please address my comment in "frontend-forwarding.f90" before landing this) Comment at: flang/test/Driver/frontend-forwarding.f90:26 +! RUN: %flang -### %s 2>&1 \ +! RUN: -fopti

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:166-171 + clang::driver::options::OPT_fno_stack_arrays, false)) opts.StackArrays = 1; - } + if (args.hasFlag(clang::driver::options::OPT_floop_versioning, -

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 543571. victorkingi marked 3 inline comments as done. victorkingi added a comment. minor cleanup - dropped braces on single line if statements - moved opt_record options into [CC1Option, FC1Option, NoDriverOption] Group in clang/include/clang/Driver/Opti

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

awarzynski added a comment. Thanks for working on this, LG! I've left a few minor comments inline. Comment at: clang/include/clang/Driver/Options.td:6449-6455 +def opt_record_file : Separate<["-"], "opt-record-file">, Flags<[FC1Option, CC1Option]>, + HelpText<"File name to us

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

tblah accepted this revision. tblah added a comment. This revision is now accepted and ready to land. This looks good to me. Thanks for your efforts on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/ https://reviews.llvm.org/D155452

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 543424. victorkingi added a comment. no changes rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/ https://reviews.llvm.org/D155452 Files: clang/include/clang/Driver/Options.td clang/li

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 542838. victorkingi added a comment. No changes rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/ https://reviews.llvm.org/D155452 Files: clang/include/clang/Driver/Options.td clang/li

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 542407. victorkingi added a comment. Addressed kiranchandramohan comment on fsave-optimization-record.f90 test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/ https://reviews.llvm.org/D155452

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 542404. victorkingi added a comment. Attempt to fix failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/ https://reviews.llvm.org/D155452 Files: clang/include/clang/Driver/Options.td

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

kiranchandramohan added a comment. Please check the failing test. Comment at: flang/test/Driver/fsave-optimization-record.f90:14 +! RUN: rm -f %t.opt.yaml +! RUN: %flang -fsave-optimization-record -S -o %t.o %s +! RUN: cat %t.opt.yaml | FileCheck %s

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 541930. victorkingi marked an inline comment as done. victorkingi added a comment. Fixed failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/ https://reviews.llvm.org/D155452 Files: cla

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi marked 4 inline comments as done. victorkingi added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:398 + if (const Arg *A = Args.getLastArg(options::OPT_fsave_optimization_record_EQ)) +Format = A->getValue(); + tblah wrote: >

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi updated this revision to Diff 541563. victorkingi added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155452/new/ https://reviews.llvm.org/D155452 Files: clang/include/clang/Driver/Options.td clang/lib

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

tblah added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:398 + if (const Arg *A = Args.getLastArg(options::OPT_fsave_optimization_record_EQ)) +Format = A->getValue(); + What happens if an invalid or unsupported format is specified. Is

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

kiranchandramohan added a comment. Couple of quick comments. You probably need another frontend-forwarding test to check `fsave-optimization-record=`. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:392-395 +static void renderRemarksOptions(const ArgList &Args, ArgStringLis

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

victorkingi created this revision. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added a subscriber: sunshaoce. Herald added projects: Flang, All. victorkingi requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert, MaskRay. Herald added