This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rGee032bccc934: [clangd] Add BlockEnd comments for control
flow statements (authored by sammccall).
Change
sammccall marked 3 inline comments as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/InlayHints.cpp:252
+// This is used to summarize e.g. the condition of a while loop.
+std::string summarizeExpr(const Expr *E) {
+ struct Namer : ConstStmtVisitor {
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks, this looks like in a good shape. I left comments with some thoughts and
nits, but they're not blockers, feel free to land it.
Comment at: clang-tools-extra/clangd/In
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
The
